Skip to content

Conversation

johnoliver
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@Copilot Copilot AI review requested due to automatic review settings September 19, 2025 16:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive database sample demonstrating how to use Semantic Kernel with MySQL database for vector storage operations. The sample includes vector search functionality using OpenAI embeddings and shows how to store and retrieve GitHub file information.

Key changes:

  • Complete MySQL database sample with Docker setup and vector operations
  • Cleanup of reactor-core dependency from semantickernel-api-data and moved to data-jdbc module
  • Minor Docker case standardization fix for presidio sample

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
samples/semantickernel-demos/sk-database-sample/* New complete database sample with Maven project, Docker setup, and vector storage demonstration
semantickernel-api-data/pom.xml Removes reactor-core dependency that was likely moved to appropriate module
data/semantickernel-data-jdbc/pom.xml Adds reactor-core dependency to the JDBC data module where it's actually needed
samples/semantickernel-demos/pom.xml Adds new database sample module to parent POM
samples/semantickernel-demos/sk-presidio-sample/sk-presidio-sample-dockerfile Standardizes Docker FROM statement case

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

karianna
karianna previously approved these changes Sep 20, 2025
…com/microsoft/semantickernel/GitHubFile.java
Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to review this properly later on

# specific language governing permissions and limitations
# under the License.
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.3/apache-maven-3.9.3-bin.zip
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a newer wrapper version IIRC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants