-
Notifications
You must be signed in to change notification settings - Fork 50
add database example #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add database example #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive database sample demonstrating how to use Semantic Kernel with MySQL database for vector storage operations. The sample includes vector search functionality using OpenAI embeddings and shows how to store and retrieve GitHub file information.
Key changes:
- Complete MySQL database sample with Docker setup and vector operations
- Cleanup of reactor-core dependency from semantickernel-api-data and moved to data-jdbc module
- Minor Docker case standardization fix for presidio sample
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
samples/semantickernel-demos/sk-database-sample/* | New complete database sample with Maven project, Docker setup, and vector storage demonstration |
semantickernel-api-data/pom.xml | Removes reactor-core dependency that was likely moved to appropriate module |
data/semantickernel-data-jdbc/pom.xml | Adds reactor-core dependency to the JDBC data module where it's actually needed |
samples/semantickernel-demos/pom.xml | Adds new database sample module to parent POM |
samples/semantickernel-demos/sk-presidio-sample/sk-presidio-sample-dockerfile | Standardizes Docker FROM statement case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ickernel-demos/sk-database-sample/src/main/java/com/microsoft/semantickernel/GitHubFile.java
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
...ickernel-demos/sk-database-sample/src/main/java/com/microsoft/semantickernel/GitHubFile.java
Show resolved
Hide resolved
…com/microsoft/semantickernel/GitHubFile.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to review this properly later on
# specific language governing permissions and limitations | ||
# under the License. | ||
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.3/apache-maven-3.9.3-bin.zip | ||
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a newer wrapper version IIRC
Motivation and Context
Description
Contribution Checklist