Skip to content

Conversation

@srietkerk
Copy link
Contributor

Fixes https://github.com/microsoft/pxt-minecraft/issues/2655

There are blocks categories, in this case the agent category, that use images for their category icon rather than an icon within our font library. This change allows us to support these in the tutorial inline block styles.

image

Upload target: https://minecraft.makecode.com/app/7e56fe5acb243e068f9ed4aa6a11126b94008019-2870f4b5c3#

@srietkerk srietkerk requested a review from a team November 16, 2024 00:46
Copy link
Contributor

@thsparks thsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@srietkerk srietkerk merged commit 6631879 into master Nov 18, 2024
7 checks passed
@srietkerk srietkerk deleted the srietkerk/agent-icon-bug branch November 18, 2024 18:03
srietkerk added a commit that referenced this pull request Nov 18, 2024
* fix the tabbing for has categories check

* add support for image icons in inline blocks in tutorials
srietkerk added a commit that referenced this pull request Nov 18, 2024
#10273)

* fix the tabbing for has categories check

* add support for image icons in inline blocks in tutorials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants