Skip to content

fix(trace-viewer): restore displaying selected call title in call tab #37898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
+6 −3
Merged

fix(trace-viewer): restore displaying selected call title in call tab #37898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
802c129
fix(trace-viewer): restore displaying selected call title in call tab
agg23 Oct 17, 2025
aa90b60
Update tests
agg23 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/trace-viewer/src/ui/callTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { asLocator } from '@isomorphic/locatorGenerators';
import type { Language } from '@isomorphic/locatorGenerators';
import { PlaceholderPanel } from './placeholderPanel';
import type { ActionTraceEventInContext } from './modelUtil';
import { renderTitleForCall } from './actionList';

export const CallTab: React.FunctionComponent<{
action: ActionTraceEventInContext | undefined,
Expand All @@ -40,9 +41,11 @@ export const CallTab: React.FunctionComponent<{
const startTimeMillis = action.startTime - startTimeOffset;
const startTime = msToString(startTimeMillis);

const { title } = renderTitleForCall(action);

return (
<div className='call-tab'>
<div className='call-line'>{action.title}</div>
<div className='call-line'>{title}</div>
<div className='call-section'>Time</div>
<DateTimeCallLine name='start:' value={startTime} />
<DateTimeCallLine name='duration:' value={renderDuration(action)} />
Expand Down
4 changes: 2 additions & 2 deletions tests/library/trace-viewer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ test('should show params and return value', async ({ showTraceViewer }) => {
const traceViewer = await showTraceViewer(traceFile);
await traceViewer.selectAction('Evaluate');
await expect(traceViewer.callLines).toHaveText([
'',
/Evaluate/,
/start:[\d\.]+m?s/,
/duration:[\d]+ms/,
/expression:"\({↵ a↵ }\) => {↵ console\.log\(\'Info\'\);↵ console\.warn\(\'Warning\'\);↵ console/,
Expand All @@ -329,7 +329,7 @@ test('should show null as a param', async ({ showTraceViewer, browserName }) =>
const traceViewer = await showTraceViewer(traceFile);
await traceViewer.selectAction('Evaluate', 1);
await expect(traceViewer.callLines).toHaveText([
'',
/Evaluate/,
/start:[\d\.]+m?s/,
/duration:[\d]+ms/,
'expression:"() => 1 + 1"',
Expand Down