Skip to content

chore(trace-viewer): improve aria tab roles #37872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(trace-viewer): improve aria tab roles #37872

wants to merge 3 commits into from
+16 −11

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Oct 15, 2025 •
edited
Loading

@agg23 agg23 requested a review from pavelfeldman October 15, 2025 18:54
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
pavelfeldman
pavelfeldman reviewed Oct 15, 2025
View reviewed changes
packages/trace-viewer/src/ui/snapshotTab.css Outdated
*/

.snapshot-tabs {
display: flex;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use vbox and hbox for flex containers. What do you mean by height: 100% in a flex parent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're questioning about height: 100%. flex does not fill the off dimension by default; you have to tell the element to expand to fit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that's why we use vbox and hbox.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/test-debug.spec.ts:166 › test_debug (pause/snapshot/resume) @mcp-macos-15

2569 passed, 108 skipped

Merge workflow run.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter-html.spec.ts:362 › created › should use different path if attachments base url option is provided @macos-latest-node18-2

3 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node18`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node18`

47082 passed, 815 skipped

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agg23 @pavelfeldman