-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat(html): order by duration #37864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
35ab3f3
feat(html-reporter): add sorting support for test results
Skn0tt 1f31366
refactor(html-reporter): simplify Filter.parse() method
Skn0tt aa677de
refactor(html-reporter): make sortTests mutate in place
Skn0tt dba8f75
test(html-reporter): add cross-file sorting test
Skn0tt 3277f4e
fix(html-reporter): disable file grouping when sorting is enabled
Skn0tt dc5c8fe
test(html-reporter): use aria snapshots for sorting test
Skn0tt 0feb87d
refactor(test): trim aria snapshots to essential elements
Skn0tt d29bb82
refactor(test): use getByRole('main') for narrower scope
Skn0tt 709eaeb
flip ordering
Skn0tt 737a175
annot, not tag
Skn0tt f7b68f2
move sort into clause
Skn0tt 1e43b8c
feat(html-reporter): add sorting by duration
Skn0tt 44bd486
feat(html-reporter): add support for additional sort fields
Skn0tt f487e6f
add default sorting
Skn0tt 7febe1e
test(html-reporter): extend sorting test coverage
Skn0tt 4f6b6e9
ensure text is only used as last resort
Skn0tt 0b5e259
chunk by 100
Skn0tt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sets got useless through #35390.