feat(test runner): config.tag for a global tag #37846
Conversation
Test results for "MCP"2550 passed, 102 skipped Merge workflow run. |
Test results for "tests 1"2 failed 2 flaky47017 passed, 816 skipped Merge workflow run. |
| export default defineConfig({ | ||
| reporter: [['blob', { outputFile: `./blob-report/report-${os.platform()}.zip` }]], | ||
| reporter: 'blob', | ||
| tag: process.env.CI_ENVIRONMENT_NAME, // for example "@APIv2" |
There was a problem hiding this comment.
let's include platform name in the example: ['@apiv2', 'linux']. This is important for the case of running the same project on multiple platforms.
| const tags = sanitizeForFilePath(config.tags.map(tag => tag.substring(1)).join('-')).substring(0, 50); | ||
| reportName = `${reportName}-${tags}`; | ||
| } | ||
| if (this._options._commandHash) |
There was a problem hiding this comment.
Let's include tags into the inputs for the hash - for the case when the tags are long and we may end up with clashing 50 chars prefixes.
| version: currentBlobReportVersion, | ||
| userAgent: getUserAgent(), | ||
| name: process.env.PWTEST_BOT_NAME, | ||
| name: process.env.PWTEST_BOT_NAME || config.tags.join(' '), |
There was a problem hiding this comment.
Can we read the tags from the config event instead of storing them in the name?
3 participants
No description provided.