Added validation for ContiguousBufferMemory construction#2944
Open
ben-zen wants to merge 5 commits intomicrosoft:mainfrom
Open
Added validation for ContiguousBufferMemory construction#2944ben-zen wants to merge 5 commits intomicrosoft:mainfrom
ben-zen wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds input validation to ContiguousBufferManager construction to ensure ring-buffer indexing remains correct across u32 wrap-around, and introduces a unit test to enforce the allowed page_limit values.
Changes:
- Add a constructor-time validation for
page_limitto prevent invalid ring sizing. - Add a unit test that checks only power-of-two page counts are accepted.
You can also share your feedback on Copilot code review. Take the survey.
ben-zen
force-pushed
the
validate_ring_buffer
branch
from
a5a0065 to
11ca577
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContiguousBufferMemory works by having a rolling
len-sized window of valid offsets across allu32values. The only safe window sizes are therefore powers of 2, otherwise you can potentially have multiple buffers assigned the same offset near the end of theu32space, due to how modular arithmetic rolls over values.