netvsp: gdma driver advertises eqe 135 capabilities to the soc#2933
Open
erfrimod wants to merge 7 commits intomicrosoft:mainfrom
Open
netvsp: gdma driver advertises eqe 135 capabilities to the soc#2933erfrimod wants to merge 7 commits intomicrosoft:mainfrom
erfrimod wants to merge 7 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MANA GDMA VF driver to advertise EQE 135-related capabilities to the SoC/PF and adjusts teardown behavior after VF reconfiguration events (EQE 135), with accompanying test coverage updates.
Changes:
- Advertise additional GDMA driver capability flags (SELF_RESET_ON_EQE_NOTIFICATION, VTL2_REVOKE_SUB_ON_RESET_EQE).
- Log PF capability flags returned by VERIFY_VF_DRIVER_VERSION.
- Treat EQE 135 as “HWC no longer responsive” by setting the HWC timeout to 0 and extending the unit test to validate the new behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vm/devices/net/mana_driver/src/tests.rs | Enhances the EQE 135 test to assert timeout changes and HWC failure behavior during teardown. |
| vm/devices/net/mana_driver/src/gdma_driver.rs | Advertises new caps, logs PF caps, sets HWC timeout to 0 on EQE 135, and tweaks deregister timeout handling; adds test-only getters. |
| vm/devices/net/gdma_defs/src/lib.rs | Adds missing capability flag constants used by the driver and for PF capability logging. |
Contributor
Author
|
Tested on a lab machine, these are the socmana logs which show the SoC sees the updated capabilities falgs:
0x14068 = 0x08 | 0x20 | 0x40 | 0x4000 | 0x10000 3 | 0x08 | HWC_TIMEOUT_RECONFIG |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that OpenHCL handles the EQE 135, the Gdma driver should let the SoC know that it has that capability.