Open
Conversation
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Rust toolchain baseline to 1.94 and removes now-unnecessary unsafe wrappers around certain x86_64 CPUID intrinsics.
Changes:
- Bump workspace
rust-versionto 1.94. - Update CI/rustup toolchain pins from 1.93.1 to 1.94.0 across GitHub Actions and Flowey CI.
- Remove
unsafeusage around__cpuid/__cpuid_countwhere it is now safe.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumps workspace rust-version to 1.94. |
| xsync/Cargo.toml | Bumps xsync workspace rust-version to 1.94. |
| support/safe_intrinsics/src/lib.rs | Removes unsafe call site for __cpuid_count. |
| opentmk/src/platform/hyperv/arch/x86_64/ctx.rs | Removes unsafe around __cpuid call. |
| flowey/flowey_lib_hvlite/src/cfg_rustup_version.rs | Updates pinned rustup toolchain string to 1.94.0. |
| ci-flowey/openvmm-pr.yaml | Updates rustup installation toolchain pin to 1.94.0 in Flowey CI. |
| .github/workflows/openvmm-pr.yaml | Updates rustup installation toolchain pin to 1.94.0 in PR workflow. |
| .github/workflows/openvmm-pr-release.yaml | Updates rustup installation toolchain pin to 1.94.0 in PR release workflow. |
| .github/workflows/openvmm-docs-pr.yaml | Updates rustup installation toolchain pin to 1.94.0 in docs PR workflow. |
| .github/workflows/openvmm-docs-ci.yaml | Updates rustup installation toolchain pin to 1.94.0 in docs CI workflow. |
| .github/workflows/openvmm-ci.yaml | Updates rustup installation toolchain pin to 1.94.0 in CI workflow. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could choose to inline all the cpuid calls since it's no longer unsafe, but I'll leave that for a follow up. After some discussions with Justus he'll update and refactor the Nix config somewhat.