netvsp: eqe 135 handling clashing with fhr#2909
Open
erfrimod wants to merge 2 commits intomicrosoft:mainfrom
Open
netvsp: eqe 135 handling clashing with fhr#2909erfrimod wants to merge 2 commits intomicrosoft:mainfrom
erfrimod wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the netvsp VF manager worker’s reconfiguration state machine to better tolerate VF arrival/removal events that occur during VF reconfiguration delays (e.g., EQE 135 + FHR timing), avoiding panics and inappropriate retry behavior.
Changes:
- Treat uevent “device exists” notifications as
ManaDeviceArrivedeven while inReconfiguring. - Replace a panic on device arrival during reconfig backoff with “abandon reconfiguration” behavior (clears backoff + logs).
- On device removal, clear any outstanding reconfig backoff (with logging) rather than silently resetting.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems happen when device arrival / removal occur during VF Reconfiguration delays and waits. Modifying the behavior in VF Manager to consider device arrival/removal to indicate that the old VF is gone and the reconfiguration should be abandoned.
Example: EQE 135 arrives -> delay -> FHR -> device removal