-
Notifications
You must be signed in to change notification settings - Fork 173
net: report actual MANA adapter link speed to guest #2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuqiong6
wants to merge
9
commits into
microsoft:main
Choose a base branch
from
yuqiong6:user/yuqliu/linkspeed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
25b3014
net: report actual MANA adapter link speed to guest
yuqiong6 ebaa378
Merge branch 'main' into user/yuqliu/linkspeed
yuqiong6 9eeaacd
Merge branch 'main' into user/yuqliu/linkspeed
yuqiong6 f22e46c
net_mana: add missing fields to ManaQueryDeviceCfgResp in tests
yuqiong6 a4ec6f5
Merge branch 'main' into user/yuqliu/linkspeed
yuqiong6 247ed49
Merge branch 'main' into user/yuqliu/linkspeed
yuqiong6 405b369
mana: use MANA_QUERY_DEV_CONFIG_REQUEST_V1 for query_dev_config reque…
yuqiong6 0827c21
Merge branch 'main' into user/yuqliu/linkspeed
yuqiong6 9f501c5
net/mana: zero response page before HWC request
yuqiong6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -568,6 +568,9 @@ async fn test_vport_with_query_filter_state(driver: DefaultDriver) { | |
| max_num_vports: 1, | ||
| reserved: 0, | ||
| max_num_eqs: 64, | ||
| adapter_mtu: 0, | ||
| reserved2: 0, | ||
| adapter_link_speed_mbps: 0, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we have a variation of the test where this is getting populated with a non-zero value and then later it checks that the query returns the right link speed on the adapter? |
||
| }; | ||
| let thing = ManaDevice::new(&driver, device, 1, 1, None).await.unwrap(); | ||
| let _ = thing.new_vport(0, None, &dev_config).await.unwrap(); | ||
|
|
@@ -729,6 +732,9 @@ async fn test_endpoint( | |
| max_num_vports: 1, | ||
| reserved: 0, | ||
| max_num_eqs: 64, | ||
| adapter_mtu: 0, | ||
| reserved2: 0, | ||
| adapter_link_speed_mbps: 0, | ||
| }; | ||
| let thing = ManaDevice::new(&driver, device, 1, 1, None).await.unwrap(); | ||
| let vport = thing.new_vport(0, None, &dev_config).await.unwrap(); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.