AdvLoggerPkg: Initialize structures in LineParserTestApp#828
Merged
makubacki merged 1 commit intomicrosoft:release/202502from Feb 10, 2026
Conversation
Logger info structures are not zeroed and initialized right now, causing garbage data to be read in some fields and impact test results. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
mu-automation
bot
added
the
impact:non-functional
os-d
approved these changes
Feb 10, 2026
kuqin12
approved these changes
Feb 10, 2026
Contributor
kuqin12
left a comment
kuqin12
left a comment
There was a problem hiding this comment.
The change looks good. But I still would like to get rid of the test and its underlying library at some point..
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #828 +/- ##
================================================
Coverage ? 4.70%
================================================
Files ? 36
Lines ? 4205
Branches ? 276
================================================
Hits ? 198
Misses ? 4005
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
Sounds good. This is just keeping the wheels turning for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logger info structures are not zeroed and initialized right now, causing garbage data to be read in some fields and impact test results.
How This Was Tested
Integration Instructions