[CHERRY-PICK] MdeModulePkg: Allow dynamic generation of HEST ACPI table#1659
Merged
os-d merged 1 commit intomicrosoft:release/202511from Feb 26, 2026
Merged
[CHERRY-PICK] MdeModulePkg: Allow dynamic generation of HEST ACPI table#1659os-d merged 1 commit intomicrosoft:release/202511from
os-d merged 1 commit intomicrosoft:release/202511from
Conversation
makubacki
approved these changes
Feb 26, 2026
Member
makubacki
left a comment
makubacki
left a comment
There was a problem hiding this comment.
I know this is cherry-picked but I left some comments to fix and take as feedback. Looks like CI caught the library not being built in MdeModulePkg.dsc.
apop5
approved these changes
Feb 26, 2026
cfernald
approved these changes
Feb 26, 2026
Introduce the HEST table generation protocol that allows platforms to build the table with multiple error source descriptors and install the table. The protocol provides two interfaces. The first interface allows for adding multiple error source descriptors into the HEST table. The second interface can then be used to dynamically install the fully populated HEST table. This allows multiple drivers and/or libraries to dynamically register error source descriptors into the HEST table. Co-authored-by: Thomas Abraham <thomas.abraham@arm.com> Signed-off-by: Omkar Anand Kulkarni <omkar.kulkarni@arm.com> Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
kuqin12
approved these changes
Feb 26, 2026
makubacki
approved these changes
Feb 26, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1659 +/- ##
=================================================
Coverage ? 1.84%
=================================================
Files ? 1151
Lines ? 375732
Branches ? 3196
=================================================
Hits ? 6936
Misses ? 368740
Partials ? 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce the HEST table generation protocol that allows platforms to build the table with multiple error source descriptors and install the table. The protocol provides two interfaces. The first interface allows for adding multiple error source descriptors into the HEST table. The second interface can then be used to dynamically install the fully populated HEST table. This allows multiple drivers and/or libraries to dynamically register error source descriptors into the HEST table.
Note: This is cherry-picked from https://git.gitlab.arm.com/arm-reference-solutions/edk2/-/commit/2dcd7973c295ec7e2a16b17126e6c5f5bbdfe98c not edk2. The owners are being worked with to upstream this to edk2.
How This Was Tested
Tested on physical ARM64 platform.
Integration Instructions
N/A.