[2502] NetworkPkg/UefiPxeBcDxe: Add missing Token.Context initialization#1656
Merged
makubacki merged 1 commit intomicrosoft:release/202502from Feb 26, 2026
Merged
Conversation
5 tasks
apop5
approved these changes
Feb 25, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1656 +/- ##
================================================
Coverage ? 0.55%
================================================
Files ? 165
Lines ? 72030
Branches ? 1788
================================================
Hits ? 402
Misses ? 71621
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
os-d
approved these changes
Feb 25, 2026
kuqin12
approved these changes
Feb 25, 2026
Adds missing `Token.Context = Private` initialization in two MTFTP write-file functions. Without this, the `Context` field passed to the MTFTP `WriteFile` callback was uninitialized, which could lead to a page fault when the callback attempted to access the `Private` driver context. The corresponding read-file functions already set this field correctly. This has been an issue since the initial implementation of NetworkPkg (2010). Co-authored-by: Wenbo Hou <wenbhou@microsoft.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
uefipxebcdxe_pxebcmtfp_init
branch
from
03afeb8 to
827e68e
Compare
apop5
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing
Token.Context = Privateinitialization in two MTFTP write-file functions. Without this, theContextfield passed to the MTFTPWriteFilecallback was uninitialized, which could lead to a page fault when the callback attempted to access thePrivatedriver context. The corresponding read-file functions already set this field correctly.This has been an issue since the initial implementation of NetworkPkg (2010).
How This Was Tested
Test file write to TFTP server with memory protections enabled.
Integration Instructions