Skip to content

Conversation

@pomahade
Copy link
Contributor

vsmb.go code is called for main.go, it starts the lanmanworkstation service, creates redirector instance and binds it to the vmbus. We can then use shimdiag share to share between host and guest.

@pomahade
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@pomahade pomahade force-pushed the main branch 2 times, most recently from 07066a4 to 35ee620 Compare November 13, 2025 01:52
Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can add testing for the code in internal/gcs-sidecar/vsmb.go?
Theres a lot of error-prone looking Win32 interactions

@pomahade
Copy link
Contributor Author

Is there any way we can add testing for the code in internal/gcs-sidecar/vsmb.go? Theres a lot of error-prone looking Win32 interactions
Any failure in vsmb will not fail gcs-sidecar, none of them return error back, the logs ensure we capture what step fails. We could discuss what testing can be added but that can be addressed separately.

Signed-off-by: Pooja Mahadev Soundalgekar <[email protected]>
startReq.Reserved1 = 0
startReq.InstanceConfig = SMB2InstanceConfiguration{}
startReq.DefaultConnectionProperties = LMRConnectionProperties{}
startReq.DefaultConnectionProperties.Flags1 = 0x1F
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also initialize it inline, e.g.
we can cleanup later though.

startReq := LMRStartInstanceRequest {
    DefaultConnectionProperties: LMRConnectionProperties {
        Flags1 = 0x1f
        ...
    }

@pomahade pomahade merged commit ff0b3a5 into microsoft:main Nov 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants