-
Notifications
You must be signed in to change notification settings - Fork 275
vsmb share redirector start and bind to vmbus #2560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@microsoft-github-policy-service agree company="Microsoft" |
07066a4 to
35ee620
Compare
helsaawy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can add testing for the code in internal/gcs-sidecar/vsmb.go?
Theres a lot of error-prone looking Win32 interactions
|
Signed-off-by: Pooja Mahadev Soundalgekar <[email protected]>
| startReq.Reserved1 = 0 | ||
| startReq.InstanceConfig = SMB2InstanceConfiguration{} | ||
| startReq.DefaultConnectionProperties = LMRConnectionProperties{} | ||
| startReq.DefaultConnectionProperties.Flags1 = 0x1F |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could also initialize it inline, e.g.
we can cleanup later though.
startReq := LMRStartInstanceRequest {
DefaultConnectionProperties: LMRConnectionProperties {
Flags1 = 0x1f
...
}
vsmb.go code is called for main.go, it starts the lanmanworkstation service, creates redirector instance and binds it to the vmbus. We can then use shimdiag share to share between host and guest.