C-WCOW: SecurityPolicy and sidecar fixes #2527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahati Chamarthy <[email protected]>
Signed-off-by: Mahati Chamarthy <[email protected]>
MahatiC
force-pushed
the
securitypolicy-review
branch
from
0e7cadb to
95ea954
Compare
Member
Author
Member
Author
|
@msscotb Can this get a reviewer assigned please? |
anmaxvl
reviewed
Nov 12, 2025
| if isInitExec { | ||
| // if this is an exec of Container command line, then it's already enforced | ||
| // during container creation, hence skip it here | ||
| c.commandLineExec = true |
Contributor
There was a problem hiding this comment.
is this basically "init process started" indicator? or rather "init process start attempted"
Contributor
There was a problem hiding this comment.
also, is the assumption that no out of order exec requests will come?
Member
Author
There was a problem hiding this comment.
Requests are handled sequentially by gcs-sidecar. Also, isInitExec is a misnomer as it has nothing to do with init, I have changed the variable name. This is specifically to differentiate the exec at start container vs other exec processes.
Signed-off-by: Mahati Chamarthy <[email protected]>
MahatiC
force-pushed
the
securitypolicy-review
branch
from
95ea954 to
d7e2efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.