Skip to content

Validate NuGet binary closures during packaging #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
brendankowitz wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Validate NuGet binary closures during packaging #5676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6c98fe2
Document NuGet binary closure validation
brendankowitz Jul 14, 2026
4b87a66
Plan NuGet binary closure validation
brendankowitz Jul 14, 2026
e52e490
Add NuGet closure validation helpers
brendankowitz Jul 14, 2026
2abfc59
Sort discovered package frameworks
brendankowitz Jul 14, 2026
ce205ea
Resolve restore config output paths
brendankowitz Jul 14, 2026
cd3c208
Validate restored NuGet binary closures
brendankowitz Jul 14, 2026
d227262
Make validator errors deterministic
brendankowitz Jul 14, 2026
daeabb5
Fix local package restore validation
brendankowitz Jul 14, 2026
383dd10
Run binary closure checks during packaging
brendankowitz Jul 14, 2026
2ad2dd7
Disable central versions for closure consumers
brendankowitz Jul 14, 2026
fc30842
Preserve empty binary closure reports
brendankowitz Jul 14, 2026
a273c62
Honor binary checker baseline matches
brendankowitz Jul 14, 2026
7dc9fa9
Baseline NuGet binary closures
brendankowitz Jul 15, 2026
64975f8
Use relative binary checker input paths
brendankowitz Jul 15, 2026
d202465
Run binary checker from publish directory
brendankowitz Jul 15, 2026
a05e43a
Regenerate binary closure baselines on Linux
brendankowitz Jul 15, 2026
c9cea3c
Resolve PowerShell child executable
brendankowitz Jul 15, 2026
71dd7f1
Correct binary closure plan inventory
brendankowitz Jul 15, 2026
8c684fb
Reduce binary closure validation scope
brendankowitz Jul 15, 2026
4d29bd8
Plan reduced binary closure validation
brendankowitz Jul 15, 2026
1658058
Select binary closure deployment roots
brendankowitz Jul 15, 2026
5735bfd
Validate Web package deployment closures
brendankowitz Jul 15, 2026
a262ad7
Test renamed dependency member failures
brendankowitz Jul 15, 2026
697c31f
Make member regression fixture portable
brendankowitz Jul 15, 2026
36a4073
Reduce binary closure baseline inventory
brendankowitz Jul 15, 2026
12a33ce
Preserve binary closure package roots
brendankowitz Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,021 changes: 1,021 additions & 0 deletions build/binarycompat/Microsoft.Health.Fhir.R4.Web.net8.0.txt
View file
Open in desktop

Large diffs are not rendered by default.

484 changes: 484 additions & 0 deletions build/binarycompat/Microsoft.Health.Fhir.R4.Web.net9.0.txt
View file
Open in desktop

Large diffs are not rendered by default.

1,016 changes: 1,016 additions & 0 deletions build/binarycompat/Microsoft.Health.Fhir.R4B.Web.net8.0.txt
View file
Open in desktop

Large diffs are not rendered by default.

479 changes: 479 additions & 0 deletions build/binarycompat/Microsoft.Health.Fhir.R4B.Web.net9.0.txt
View file
Open in desktop

Large diffs are not rendered by default.

1,016 changes: 1,016 additions & 0 deletions build/binarycompat/Microsoft.Health.Fhir.R5.Web.net8.0.txt
View file
Open in desktop

Large diffs are not rendered by default.

479 changes: 479 additions & 0 deletions build/binarycompat/Microsoft.Health.Fhir.R5.Web.net9.0.txt
View file
Open in desktop

Large diffs are not rendered by default.

1,020 changes: 1,020 additions & 0 deletions build/binarycompat/Microsoft.Health.Fhir.Stu3.Web.net8.0.txt
View file
Open in desktop

Large diffs are not rendered by default.

483 changes: 483 additions & 0 deletions build/binarycompat/Microsoft.Health.Fhir.Stu3.Web.net9.0.txt
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions build/jobs/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ steps:
& dotnet pack $(Build.SourcesDirectory) --output $(Build.ArtifactStagingDirectory)/nupkgs --no-build --configuration=Release -p:PackageVersion=$(nuGetVersion)
name: PackNugets

- template: ../steps/validate-nuget-binary-closure.yml
parameters:
packageDirectory: '$(Build.ArtifactStagingDirectory)/nupkgs'
baselineDirectory: '$(Build.SourcesDirectory)/build/binarycompat'
reportDirectory: '$(Build.ArtifactStagingDirectory)/binarycompat'
workDirectory: '$(Agent.TempDirectory)/binarycompat'
nuGetConfigPath: '$(Build.SourcesDirectory)/nuget.config'

# Publish artifacts
- task: PublishBuildArtifacts@1
displayName: 'publish web artifacts'
Expand Down
Loading
Loading