Harden Bulk Delete Error Handling#5666
Open
LTA-Thinking wants to merge 2 commits into
Open
Conversation
added 2 commits
July 10, 2026 09:08
LTA-Thinking
added
Bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Verify that partial results contain the first page of deleted resources | ||
| Assert.NotNull(exception.PartialResults); | ||
| Assert.True(exception.PartialResults.ContainsKey("Patient")); |
Comment on lines
+444
to
+451
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Error soft deleting"); | ||
| await CreateAuditLog(request.ResourceType, request.DeleteOperation, true, partialResults); | ||
| throw new IncompleteOperationException<Dictionary<string, long>>( | ||
| ex, | ||
| partialResults.GroupBy(pair => pair.ResourceType).ToDictionary(group => group.Key, group => (long)group.Count())); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Catches exceptions that happen outside of parallel threads, preventing false reporting of job success.
Related issues
Addresses Bug 189017
Testing
New unit test
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)