feat: supports digital twin builder flow item#235
Conversation
| _workspace_id = item.workspace.id | ||
|
|
||
| if _digital_twin_builder_id: | ||
| payload_dict["creationPayload"] = { |
There was a problem hiding this comment.
since both conditions adding the same creationMethod to payload, consider changing the check to
if !digital_twin_builder_id:
create ......
then no need for else, just set the payload_dict["creationPayload"] = ......
| @@ -44,136 +44,263 @@ | |||
|
|
|||
| ALL_ITEM_TYPES = [ | |||
There was a problem hiding this comment.
it is very hard to review this page because of all the changes... can you explain what you did? added DIGITAL_TWIN_BUILDER_FLOW type to the functions? I see it was added to only several method.. why?
| @@ -18,7 +18,10 @@ | |||
| from fabric_cli.errors import ErrorMessages | |||
| from tests.test_commands.commands_parser import CLIExecutor | |||
| from tests.test_commands.conftest import ( | |||
There was a problem hiding this comment.
was something changed here? or only the formating?
| @@ -11,12 +11,12 @@ interactions: | |||
| Content-Type: | |||
There was a problem hiding this comment.
recordings for export are missing?
| @@ -100,9 +100,7 @@ def test_mkdir_unsupported_item_failure( | |||
| workspace = workspace_factory() | |||
|
|
|||
| # Create unsupported item | |||
There was a problem hiding this comment.
also here, only formatting was changed?
try use the same formatting so you'll not have those diffs - will be easier to review
Onboards Digital Twin Builder Flow item type & records tests for its commands.