refactor: show error message#233
Open
v-alexmoraru wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates FabricAPIError to better surface raw error bodies when the Fabric API response can’t be parsed as JSON, and avoids printing a “Request Id” line when the ID is missing.
Changes:
- Wrap Fabric API error-body parsing in a
try/exceptto fall back to the raw response text onJSONDecodeError. - Only append “Request Id” to the formatted message when a request id is present.
aviatco
reviewed
May 11, 2026
| self.request_id = response.get("requestId") | ||
| try: | ||
| response = json.loads(response_text) | ||
| if not isinstance(response, dict): |
Collaborator
There was a problem hiding this comment.
I think response_text can be a string, not always an object. but Im not sure. worth checking it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows Fabric API error message more explicitly.