Skip to content

Conversation

ekzhu
Copy link
Contributor

@ekzhu ekzhu commented Sep 29, 2025

Motivation and Context

So we can properly skip tests in lab and devui in the main CI build

Description

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@Copilot Copilot AI review requested due to automatic review settings September 29, 2025 22:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the Python test execution to use a consistent script-based approach for running tests across packages while properly handling package exclusions. The main goal is to enable proper skipping of tests in lab and devui packages in the CI build.

  • Replaced direct pytest command with script-based approach using run_tasks_in_packages_if_exists.py
  • Added command-line argument parsing to support dynamic package exclusions
  • Consolidated test execution methods by removing the separate all-tests-cov task

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
python/run_tasks_in_packages_if_exists.py Enhanced script with argparse support and exclude functionality for flexible package filtering
python/pyproject.toml Simplified test tasks by replacing direct pytest commands with script-based approach
.github/workflows/python-test-coverage.yml Updated CI to use unified test command instead of separate coverage task

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ekzhu ekzhu enabled auto-merge September 30, 2025 00:44
-n logical --dist loadfile --dist worksteal
packages/**/tests
"""
cmd = "python run_tasks_in_packages_if_exists.py test --exclude packages/lab --exclude packages/devui"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much slower because it will have to setup and breakdown for each package

@ekzhu ekzhu closed this Sep 30, 2025
auto-merge was automatically disabled September 30, 2025 22:34

Pull request was closed

@ekzhu ekzhu deleted the ekzhu/update-all-tests branch September 30, 2025 22:34
@ekzhu ekzhu restored the ekzhu/update-all-tests branch September 30, 2025 22:35
@ekzhu ekzhu reopened this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants