-
Notifications
You must be signed in to change notification settings - Fork 237
Python: use run_tasks_in_packages_if_exists script for all-tests #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the Python test execution to use a consistent script-based approach for running tests across packages while properly handling package exclusions. The main goal is to enable proper skipping of tests in lab and devui packages in the CI build.
- Replaced direct pytest command with script-based approach using
run_tasks_in_packages_if_exists.py
- Added command-line argument parsing to support dynamic package exclusions
- Consolidated test execution methods by removing the separate
all-tests-cov
task
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
python/run_tasks_in_packages_if_exists.py | Enhanced script with argparse support and exclude functionality for flexible package filtering |
python/pyproject.toml | Simplified test tasks by replacing direct pytest commands with script-based approach |
.github/workflows/python-test-coverage.yml | Updated CI to use unified test command instead of separate coverage task |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
-n logical --dist loadfile --dist worksteal | ||
packages/**/tests | ||
""" | ||
cmd = "python run_tasks_in_packages_if_exists.py test --exclude packages/lab --exclude packages/devui" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much slower because it will have to setup and breakdown for each package
Motivation and Context
So we can properly skip tests in lab and devui in the main CI build
Description
Contribution Checklist