Repository navigation
Recover clients when hosted lobby authority departs - #36
Merged
James Lenell (jameslen-atg) merged 1 commit intoNov 16, 2026
Merged
Conversation
Preserve the audited host-disconnect work on current upstream. Observe Party peer-left and hosted lobby changes, defer session teardown, and cover host loss through loading, countdown, gameplay, and popups. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
James Lenell (jameslen-atg)
requested review from
a team
and
a balanced review from Copilot
November 16, 2026 18:56
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the host-departure recovery changes.
No open issues 🎉
What changed in this PR
Improves client recovery when a hosted lobby’s pinned host departs, returning clients to the main menu during loading, countdown, gameplay, or while popups are open.
Changes:
- Observes Party peer departures and hosted-lobby updates, deferring authority checks and fencing stale session notices.
- Adds regression coverage for host loss, duplicate notices, retired lobbies, and continuity after local-only Lobby notification drops.
- Documents the host-departure recovery behavior.
| File | Description |
|---|---|
tools/tests/multiplayer_failure_tests.gd |
Adds a lobby state-change signal to the test fixture. |
tools/tests/cable_pull_tests.gd |
Covers host departures and Lobby notification continuity across client states. |
scripts/services/party_service.gd |
Observes lobby updates and limits peer-left notices to the attached context. |
scripts/autoload/net_manager.gd |
Connects departure notices and schedules session-fenced authority checks. |
docs/multiplayer.md |
Explains host-loss detection and deferred teardown. |
Review effort: Balanced
Member
Author
|
No changes requested by this review. The host-departure regression suite passes, and the original local worktree is preserved. 🤖 AI-authored reply via Agency Finish PR. |
James Lenell (jameslen-atg)
deleted the
jameslen-microsoft-upstream-build-audit
branch
November 16, 2026 19:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover host-disconnect changes found uncommitted during the local-to-upstream audit. Observe Party peer-left and hosted-lobby ownership/member changes so clients return to the menu when their pinned host leaves, including during loading/countdown and behind popups. Defer handling until the native notice returns, fence stale lobby updates, and preserve healthy Party sessions during local-only Lobby notification drops.
Validation
Original Host disconnect recovery worktree is unchanged. Fresh PC and Xbox Series X|S layouts will be built from upstream main after this PR merges, using its pinned addon revision.