Repository navigation
Preserve voice activity, achievement resync and platform reporting fixes - #26
Merged
James Lenell (jameslen-atg) merged 4 commits intoNov 6, 2026
Merged
Conversation
Include completed gameplay microphone controls, runtime-selected Party audio defaults, squawker polling, cache-confirmed achievement resync, expected invite cancellation handling, and console startup layout guidance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The title selects Party audio device defaults through PlayFabPartyConfig.audio_device_default_mode, which 927cdc7 does not expose. 3443fa0 is reachable on microsoft/XBOX-Godot-Sample branch jameslen-microsoft-title-selected-voice-devices and is not yet on that repo's main. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sample main 2accce5 (#212) contains the runtime-selectable Party audio defaults the title relies on; update the pin references in docs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
James Lenell (jameslen-atg)
marked this pull request as ready for review
November 6, 2026 17:50
James Lenell (jameslen-atg)
requested review from
a team
and
a balanced review from Copilot
November 6, 2026 17:50
There was a problem hiding this comment.
🔵 Needs a closer look
Mocked tests cannot verify runtime audio-device resolution, two-way speech, or console startup with the packaged native addon, so PC and console hardware validation is still needed.
No open issues 🎉
What changed in this PR
This PR improves NetRumble’s voice controls and activity indicators, makes achievement resynchronization cache-aware, and refines platform reporting behavior.
Changes:
- Adds gameplay microphone toggling, platform-specific audio defaults, and polled voice indicators.
- Serializes achievement reports, skips cache-confirmed progress, invalidates queued work at account boundaries, and treats invite cancellation as normal.
- Adds regression coverage and updates hardware-validation and console-packaging guidance.
| File | Description |
|---|---|
| tools/tests/voice_chat_tests.gd | Tests voice shortcuts, indicators, restrictions, and device defaults. |
| tools/tests/save_tests.gd | Registers the new test suites. |
| tools/tests/pregame_service_tests.gd | Requires the audio-device configuration property. |
| tools/tests/pregame_service_doubles.gd | Adds configurable platform and audio-device test state. |
| tools/tests/platform_reporting_tests.gd.uid | Adds the reporting test script’s resource identifier. |
| tools/tests/platform_reporting_tests.gd | Tests achievement queues, account boundaries, and invite outcomes. |
| tools/tests/multiplayer_failure_tests.gd | Adds voice-query methods to the failure-test backend. |
| tools/tests/doubles.gd | Adds controllable voice indicators and read tracking. |
| tools/run-save-tests.ps1 | Copies shipped input bindings into the test sandbox. |
| scripts/ui/screens/gameplay_screen.gd | Handles the gameplay microphone shortcut. |
| scripts/ui/elements/nr_roster_row.gd | Updates comments describing microphone indicators. |
| scripts/services/party_service.gd | Selects audio-device defaults by runtime platform. |
| scripts/services/matchmaking_service.gd | Checks for the required audio-device property. |
| scripts/services/chat_service.gd | Combines native voice activity with mute and privacy state. |
| scripts/services/activity_service.gd | Suppresses warnings for native invite cancellation. |
| scripts/services/achievement_service.gd | Adds cache-aware, coalesced achievement reporting. |
| scripts/autoload/services.gd | Invalidates achievement queues on account and lifecycle transitions. |
| scripts/autoload/net_manager.gd | Polls voice indicators and signals roster updates. |
| project.godot | Binds microphone toggling to V and D-pad Up. |
| docs/walkthroughs.md | Adds gameplay voice-toggle instructions. |
| docs/platform-services.md | Documents achievement caching and queue behavior. |
| docs/multiplayer.md | Updates voice behavior and addon revision guidance. |
| docs/manual-test-plan.md | Expands voice, achievement, and invite acceptance checks. |
| docs/configuration.md | Updates addon revision guidance and documents required _cl_ preservation. |
| docs/addon-maintenance.md | Documents runtime audio-device selection and addon requirements. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves completed title work from the PC-packaging session. No generated packages, DLLs, or staged package content are included.
Contents
toggle_voice_mute), Party audio defaults selected by runtime platform, and roster squawkers driven by Party voice activity (get_local_chat_indicator/get_chat_indicator). This supersedes local commits 290ca46, fc85633, and facc386 onjameslen-microsoft-local-player-voice-chat. A trial merge of facc386 changed nothing.E_ABORTis treated as a normal outcome, not a warning._cl_), plus updated test plan, multiplayer, platform-services, and configuration notes.Addon pin
The addon pin moves from
927cdc7to public microsoft/XBOX-Godot-Samplemain2accce554e0988e5076ac76d22f024307f6744c6(microsoft/XBOX-Godot-Sample#212). That commit providesPlayFabPartyConfig.audio_device_default_mode, which the title sets. The.gdextensionmanifests are unchanged, so the addon overrides need no update. The branch is merged withmain, including #25, with no conflicts.Validation
tools/check-deport.ps1 -Detailed: clean.