Skip to content

Preserve voice activity, achievement resync and platform reporting fixes - #26

Merged
James Lenell (jameslen-atg) merged 4 commits into
mainfrom
jameslen-microsoft-pc-packaging-fixes
Nov 6, 2026
Merged

James Lenell (jameslen-atg) merged 4 commits into
mainfrom
jameslen-microsoft-pc-packaging-fixes

Conversation

@jameslen-atg

@jameslen-atg James Lenell (jameslen-atg) commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Preserves completed title work from the PC-packaging session. No generated packages, DLLs, or staged package content are included.

Contents

  • Voice: direct gameplay microphone toggle (toggle_voice_mute), Party audio defaults selected by runtime platform, and roster squawkers driven by Party voice activity (get_local_chat_indicator / get_chat_indicator). This supersedes local commits 290ca46, fc85633, and facc386 on jameslen-microsoft-local-player-voice-chat. A trial merge of facc386 changed nothing.
  • Achievement resync: cache-confirmed progress, no redundant-update warnings, and pending reports invalidated on resume, sign-out, and shutdown.
  • Invite UI: native cancellation/E_ABORT is treated as a normal outcome, not a warning.
  • Docs: console startup layout guidance (the stage must include _cl_), plus updated test plan, multiplayer, platform-services, and configuration notes.
  • Tests: platform reporting and voice chat suites.

Addon pin
The addon pin moves from 927cdc7 to public microsoft/XBOX-Godot-Sample main 2accce554e0988e5076ac76d22f024307f6744c6 (microsoft/XBOX-Godot-Sample#212). That commit provides PlayFabPartyConfig.audio_device_default_mode, which the title sets. The .gdextension manifests are unchanged, so the addon overrides need no update. The branch is merged with main, including #25, with no conflicts.

Validation

  • tools/check-deport.ps1 -Detailed: clean.
  • Full headless suite on Godot 4.6.2: passed, 20,628 assertions (after merging main).
  • Not hardware-verified.

James Lenell and others added 4 commits November 6, 2026 09:15
Include completed gameplay microphone controls, runtime-selected Party audio defaults, squawker polling, cache-confirmed achievement resync, expected invite cancellation handling, and console startup layout guidance.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The title selects Party audio device defaults through PlayFabPartyConfig.audio_device_default_mode, which 927cdc7 does not expose. 3443fa0 is reachable on microsoft/XBOX-Godot-Sample branch jameslen-microsoft-title-selected-voice-devices and is not yet on that repo's main.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sample main 2accce5 (#212) contains the runtime-selectable Party audio defaults the title relies on; update the pin references in docs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jameslen-atg
James Lenell (jameslen-atg) marked this pull request as ready for review November 6, 2026 17:50
@jameslen-atg
James Lenell (jameslen-atg) requested review from a team and a balanced review from Copilot November 6, 2026 17:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Mocked tests cannot verify runtime audio-device resolution, two-way speech, or console startup with the packaged native addon, so PC and console hardware validation is still needed.

No open issues 🎉

What changed in this PR

This PR improves NetRumble’s voice controls and activity indicators, makes achievement resynchronization cache-aware, and refines platform reporting behavior.

Changes:

  • Adds gameplay microphone toggling, platform-specific audio defaults, and polled voice indicators.
  • Serializes achievement reports, skips cache-confirmed progress, invalidates queued work at account boundaries, and treats invite cancellation as normal.
  • Adds regression coverage and updates hardware-validation and console-packaging guidance.
File Description
tools/​tests/​voice_chat_tests.gd Tests voice shortcuts, indicators, restrictions, and device defaults.
tools/​tests/​save_tests.gd Registers the new test suites.
tools/​tests/​pregame_service_tests.gd Requires the audio-device configuration property.
tools/​tests/​pregame_service_doubles.gd Adds configurable platform and audio-device test state.
tools/​tests/​platform_reporting_tests.gd.uid Adds the reporting test script’s resource identifier.
tools/​tests/​platform_reporting_tests.gd Tests achievement queues, account boundaries, and invite outcomes.
tools/​tests/​multiplayer_failure_tests.gd Adds voice-query methods to the failure-test backend.
tools/​tests/​doubles.gd Adds controllable voice indicators and read tracking.
tools/​run-save-tests.ps1 Copies shipped input bindings into the test sandbox.
scripts/​ui/​screens/​gameplay_screen.gd Handles the gameplay microphone shortcut.
scripts/​ui/​elements/​nr_roster_row.gd Updates comments describing microphone indicators.
scripts/​services/​party_service.gd Selects audio-device defaults by runtime platform.
scripts/​services/​matchmaking_service.gd Checks for the required audio-device property.
scripts/​services/​chat_service.gd Combines native voice activity with mute and privacy state.
scripts/​services/​activity_service.gd Suppresses warnings for native invite cancellation.
scripts/​services/​achievement_service.gd Adds cache-aware, coalesced achievement reporting.
scripts/​autoload/​services.gd Invalidates achievement queues on account and lifecycle transitions.
scripts/​autoload/​net_manager.gd Polls voice indicators and signals roster updates.
project.godot Binds microphone toggling to V and D-pad Up.
docs/​walkthroughs.md Adds gameplay voice-toggle instructions.
docs/​platform-services.md Documents achievement caching and queue behavior.
docs/​multiplayer.md Updates voice behavior and addon revision guidance.
docs/​manual-test-plan.md Expands voice, achievement, and invite acceptance checks.
docs/​configuration.md Updates addon revision guidance and documents required _cl_ preservation.
docs/​addon-maintenance.md Documents runtime audio-device selection and addon requirements.

Review effort: Balanced

@jameslen-atg
James Lenell (jameslen-atg) merged commit 32d38fb into main Nov 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants