Use Partial<T> instead of Omit<T, keyof T> when rest spreading #62573

RyanCavanaugh · 2025-10-09T16:04:52Z

#62572 seemed like a good idea worth trying

Implements suggestion from microsoft#62572

RyanCavanaugh · 2025-10-09T16:05:03Z

@copilot add testcases for this PR

RyanCavanaugh · 2025-10-09T16:05:09Z

@typescript-bot test it

typescript-bot · 2025-10-09T16:05:16Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

jakebailey · 2025-10-09T16:13:34Z

src/compiler/checker.ts

+    function isOrContainsKeyofT(keyType: Type, sourceType: Type): boolean {
+        if (keyType.flags & TypeFlags.Union) {
+            return !!forEach((keyType as UnionType).types, t => isOrContainsKeyofT(t, sourceType));
+        }
+        if (keyType.flags & TypeFlags.Index && (keyType as IndexType).type === sourceType) {
+            return true;
+        }
+        return false;
+    }


I think this traversal could be just a call to someType.

typescript-bot · 2025-10-09T16:29:39Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-10-09T16:35:36Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/62573/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2025-10-09T16:55:55Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,016k (± 0.94%)}	_{192,781k (± 0.02%)}	_~	_192,750k	_192,819k	_{p=1.000 n=6}
_{Parse Time}	_{1.30s (± 0.64%)}	_{1.30s (± 0.58%)}	_~	_1.29s	_1.31s	_{p=0.172 n=6}
_{Bind Time}	_{0.72s (± 0.71%)}	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=0.595 n=6}
_{Check Time}	_{9.73s (± 0.19%)}	_{9.78s (± 0.31%)}	_{+0.04s (+ 0.41%)}	_9.74s	_9.81s	_{p=0.044 n=6}
_{Emit Time}	_{2.75s (± 0.75%)}	_{2.74s (± 0.68%)}	_~	_2.72s	_2.77s	_{p=0.807 n=6}
_{Total Time}	_{14.51s (± 0.13%)}	_{14.54s (± 0.30%)}	_~	_14.50s	_14.61s	_{p=0.255 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_955,117	_955,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_415,619	_415,619	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,254,556k (± 0.00%)}	_{1,254,562k (± 0.01%)}	_~	_1,254,473k	_1,254,697k	_{p=0.873 n=6}
_{Parse Time}	_{6.53s (± 0.80%)}	_{6.55s (± 0.88%)}	_~	_6.44s	_6.59s	_{p=0.520 n=6}
_{Bind Time}	_{1.88s (± 0.29%)}	_{1.88s (± 0.29%)}	_~	_1.88s	_1.89s	_{p=1.000 n=6}
_{Check Time}	_{32.22s (± 0.32%)}	_{32.22s (± 0.57%)}	_~	_31.92s	_32.45s	_{p=0.810 n=6}
_{Emit Time}	_{14.84s (± 0.39%)}	_{14.87s (± 0.43%)}	_~	_14.79s	_14.94s	_{p=0.630 n=6}
_{Total Time}	_{55.47s (± 0.28%)}	_{55.52s (± 0.35%)}	_~	_55.28s	_55.87s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,038	_552,038	_~	_~	_~	_{p=1.000 n=6}
_Types	₈₉	₈₉	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{826,628k (± 0.00%)}	_{826,629k (± 0.00%)}	_~	_826,610k	_826,666k	_{p=0.748 n=6}
_{Parse Time}	_{8.67s (± 0.64%)}	_{8.67s (± 0.17%)}	_~	_8.65s	_8.69s	_{p=0.746 n=6}
_{Bind Time}	_{2.19s (± 0.41%)}	_{2.19s (± 0.34%)}	_~	_2.18s	_2.20s	_{p=0.798 n=6}
_{Check Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Emit Time}	_{0.28s (± 1.45%)}	_{0.28s (± 3.04%)}	_~	_0.26s	_0.28s	_{p=0.115 n=6}
_{Total Time}	_{11.13s (± 0.51%)}	_{11.14s (± 0.12%)}	_~	_11.12s	_11.16s	_{p=0.466 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,230	_1,237,239	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,856	_259,861	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,486,192k (±11.93%)}	_{2,546,840k (±11.94%)}	_~	_2,364,228k	_3,092,860k	_{p=0.810 n=6}
_{Parse Time}	_{5.17s (± 1.43%)}	_{5.16s (± 1.89%)}	_~	_5.07s	_5.31s	_{p=0.630 n=6}
_{Bind Time}	_{1.77s (± 1.63%)}	_{1.77s (± 0.86%)}	_~	_1.74s	_1.78s	_{p=0.934 n=6}
_{Check Time}	_{35.16s (± 0.56%)}	_{35.09s (± 0.57%)}	_~	_34.78s	_35.30s	_{p=1.000 n=6}
_{Emit Time}	_{2.99s (± 1.06%)}	_{2.98s (± 1.96%)}	_~	_2.91s	_3.07s	_{p=0.630 n=6}
_{Total Time}	_{45.10s (± 0.56%)}	_{45.01s (± 0.52%)}	_~	_44.79s	_45.42s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,230	_1,237,239	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,856	_259,861	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,158,958k (± 0.01%)}	_{3,158,235k (± 0.03%)}	_~	_3,156,769k	_3,159,558k	_{p=0.471 n=6}
_{Parse Time}	_{6.85s (± 0.89%)}	_{6.84s (± 0.27%)}	_~	_6.81s	_6.86s	_{p=0.748 n=6}
_{Bind Time}	_{2.15s (± 2.00%)}	_{2.17s (± 1.42%)}	_~	_2.14s	_2.22s	_{p=0.470 n=6}
_{Check Time}	_{42.72s (± 0.29%)}	_{42.65s (± 0.26%)}	_~	_42.53s	_42.78s	_{p=0.378 n=6}
_{Emit Time}	_{3.52s (± 1.41%)}	_{3.58s (± 3.41%)}	_~	_3.41s	_3.74s	_{p=0.629 n=6}
_{Total Time}	_{55.26s (± 0.22%)}	_{55.24s (± 0.32%)}	_~	_54.99s	_55.46s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,534	_262,543	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,035	_104,040	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{440,627k (± 0.02%)}	_{440,689k (± 0.01%)}	_~	_440,659k	_440,729k	_{p=0.066 n=6}
_{Parse Time}	_{3.51s (± 0.79%)}	_{3.50s (± 0.96%)}	_~	_3.45s	_3.54s	_{p=0.747 n=6}
_{Bind Time}	_{1.31s (± 1.15%)}	_{1.33s (± 1.43%)}	_~	_1.31s	_1.35s	_{p=0.144 n=6}
_{Check Time}	_{18.97s (± 0.42%)}	_{19.01s (± 0.25%)}	_~	_18.94s	_19.07s	_{p=0.422 n=6}
_{Emit Time}	_{1.53s (± 1.51%)}	_{1.53s (± 0.58%)}	_~	_1.52s	_1.54s	_{p=0.807 n=6}
_{Total Time}	_{25.33s (± 0.27%)}	_{25.36s (± 0.19%)}	_~	_25.31s	_25.43s	_{p=0.296 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,282k (± 0.06%)}	_{370,069k (± 0.06%)}	_~	_369,879k	_370,498k	_{p=0.109 n=6}
_{Parse Time}	_{2.82s (± 1.34%)}	_{2.82s (± 1.16%)}	_~	_2.78s	_2.86s	_{p=1.000 n=6}
_{Bind Time}	_{1.61s (± 1.07%)}	_{1.61s (± 1.38%)}	_~	_1.58s	_1.64s	_{p=1.000 n=6}
_{Check Time}	_{16.45s (± 0.42%)}	_{16.42s (± 0.13%)}	_~	_16.38s	_16.44s	_{p=0.517 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.34%)}	_{20.85s (± 0.29%)}	_~	_20.78s	_20.92s	_{p=0.629 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₆	₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,916,965	_3,916,965	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,231,412	_1,231,412	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,721,578k (± 0.00%)}	_{3,721,722k (± 0.01%)}	_~	_3,721,070k	_3,722,110k	_{p=0.230 n=6}
_{Parse Time}	_{15.23s (± 0.71%)}	_{15.21s (± 0.45%)}	_~	_15.14s	_15.33s	_{p=1.000 n=6}
_{Bind Time}	_{4.95s (± 0.56%)}	_{4.94s (± 0.60%)}	_~	_4.90s	_4.97s	_{p=0.572 n=6}
_{Check Time}	_{101.63s (± 1.23%)}	_{104.58s (± 4.64%)}	_~	_100.80s	_113.52s	_{p=0.378 n=6}
_{Emit Time}	_{38.15s (±18.82%)}	_{37.12s (±16.31%)}	_~	_30.89s	_47.08s	_{p=1.000 n=6}
_{Total Time}	_{159.96s (± 4.45%)}	_{161.84s (± 4.43%)}	_~	_155.52s	_173.35s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₄₀	₄₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_372,609	_372,609	_~	_~	_~	_{p=1.000 n=6}
_Types	_163,185	_163,185	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{529,027k (± 0.02%)}	_{528,971k (± 0.01%)}	_~	_528,909k	_529,052k	_{p=0.575 n=6}
_{Parse Time}	_{4.49s (± 0.46%)}	_{4.51s (± 0.59%)}	_~	_4.46s	_4.53s	_{p=0.052 n=6}
_{Bind Time}	_{1.92s (± 0.83%)}	_{1.93s (± 1.18%)}	_~	_1.91s	_1.97s	_{p=0.565 n=6}
_{Check Time}	_{22.14s (± 0.37%)}	_{22.15s (± 0.24%)}	_~	_22.07s	_22.21s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (±154.76%)}	_0.00s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{28.55s (± 0.28%)}	_{28.60s (± 0.18%)}	_~	_28.52s	_28.66s	_{p=0.374 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_674,800	_674,800	_~	_~	_~	_{p=1.000 n=6}
_Types	_202,613	_202,613	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{576,885k (± 0.02%)}	_{576,980k (± 0.02%)}	_~	_576,854k	_577,122k	_{p=0.298 n=6}
_{Parse Time}	_{4.17s (± 0.80%)}	_{4.18s (± 0.49%)}	_~	_4.15s	_4.20s	_{p=0.871 n=6}
_{Bind Time}	_{1.34s (± 1.03%)}	_{1.34s (± 1.10%)}	_~	_1.32s	_1.36s	_{p=0.738 n=6}
_{Check Time}	_{20.62s (± 2.18%)}	_{20.52s (± 1.81%)}	_~	_20.14s	_20.87s	_{p=0.689 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.13s (± 1.68%)}	_{26.04s (± 1.50%)}	_~	_25.65s	_26.40s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-10-09T17:22:13Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62573/merge:

Everything looks good!

Co-authored-by: RyanCavanaugh <[email protected]>

…revious-commit Add testcases for Partial<T> rest spreading with keyof T

Use Partial<T> instead of Omit<T, keyof T> when rest spreading

52fd500

Implements suggestion from microsoft#62572

typescript-bot assigned RyanCavanaugh Oct 9, 2025

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 9, 2025

jakebailey reviewed Oct 9, 2025

View reviewed changes

Copilot AI and others added 4 commits October 9, 2025 19:37

Initial plan

b1bd4cd

Add compiler test for Partial<T> rest spreading with keyof T

03d7fa1

Co-authored-by: RyanCavanaugh <[email protected]>

Add contrast test for Omit cases (not using Partial)

034278d

Co-authored-by: RyanCavanaugh <[email protected]>

Merge pull request #26 from RyanCavanaugh/copilot/add-testcases-for-p…

57242ff

…revious-commit Add testcases for Partial<T> rest spreading with keyof T

RyanCavanaugh closed this Oct 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use Partial<T> instead of Omit<T, keyof T> when rest spreading #62573

Use Partial<T> instead of Omit<T, keyof T> when rest spreading #62573

RyanCavanaugh commented Oct 9, 2025

Uh oh!

RyanCavanaugh commented Oct 9, 2025

Uh oh!

RyanCavanaugh commented Oct 9, 2025

Uh oh!

typescript-bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

jakebailey Oct 9, 2025

Uh oh!

typescript-bot commented Oct 9, 2025

Uh oh!

typescript-bot commented Oct 9, 2025

Uh oh!

typescript-bot commented Oct 9, 2025

tsc

Uh oh!

typescript-bot commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Use Partial<T> instead of Omit<T, keyof T> when rest spreading #62573

Use Partial<T> instead of Omit<T, keyof T> when rest spreading #62573

Conversation

RyanCavanaugh commented Oct 9, 2025

Uh oh!

RyanCavanaugh commented Oct 9, 2025

Uh oh!

RyanCavanaugh commented Oct 9, 2025

Uh oh!

typescript-bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Oct 9, 2025

Uh oh!

typescript-bot commented Oct 9, 2025

Uh oh!

typescript-bot commented Oct 9, 2025

tsc

Uh oh!

typescript-bot commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Oct 9, 2025 •

edited

Loading