Skip to content

Bump mdn BCD to 8.0.5 - #2557

Open
Adam Naji (Bashamega) wants to merge 3 commits into
microsoft:mainfrom
Bashamega:bump-mdn
Open

Adam Naji (Bashamega) wants to merge 3 commits into
microsoft:mainfrom
Bashamega:bump-mdn

Conversation

@Bashamega

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStream/from_static)
*/
from(asyncIterable: never): ReadableStream;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we need to deal with this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made it never what it should be?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something not never, likely AsyncIterable | Iterable per https://webidl.spec.whatwg.org/#js-async-iterable. And skip AsyncIterable where it's not available.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@saschanaz

Copy link
Copy Markdown
Contributor

Please tell the version in the PR title

@Bashamega Adam Naji (Bashamega) changed the title Bump mdn BCD Bump mdn BCD to 8.0.5 Sep 19, 2026
Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
Comment thread src/build/emitter.ts
JSON.stringify(obj),
);
return "never"; // Use 'never' to signal omission in type generation
if (compilerBehavior.treatAsyncSequence) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not letting asynciterable.d.ts emit the extra signature, it should.

@Bashamega Adam Naji (Bashamega) Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we emit to asynciterable.d.ts, I tried to understand how it emits but couldn't solve it.. feel free to cherry pick the pr if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants