Free ForAll and Self Modifying Code: Variables#3044
Open
gregli-msft wants to merge 10 commits intogregli/free-self-basefrom
Open
Free ForAll and Self Modifying Code: Variables#3044gregli-msft wants to merge 10 commits intogregli/free-self-basefrom
gregli-msft wants to merge 10 commits intogregli/free-self-basefrom
Conversation
gregli-msft
changed the title
gregli-msft
changed the title
gregli-msft
changed the title
…power-fx into gregli/free-self-var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is code in the binder to prevent writing
ForAll( DS, Remove( DS, ThisRecord.Id ) ). However, it only works for data sources, not global variables that hold tables. Which is particularly problematic because collections in Canvas apps have moved from data sources to variables and no longer have this protection.To fix this introduces a breaking change to Power Fx V1. A new feature EnhancedIterationChecks has been added with the Base version of the PR sequence to control this behavior. Existing Power Fx V1 hosts will see no change. New hosts should include this new feature which is bundled with Power Fx V2.