Skip to content

Closing guards around tcp handles #7326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Closing guards around tcp handles #7326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9bf762
Add guards around closing tcp handles
cjen1-msft Oct 1, 2025
1fd61a9
reformat
cjen1-msft Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/host/tcp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,12 @@ namespace asynchost

void on_accept(int rc)
{
if (uv_is_closing((uv_handle_t*)&uv_handle) != 0)
{
LOG_DEBUG_FMT("on_accept: closing");
return;
}

if (rc < 0)
{
LOG_DEBUG_FMT("on_accept failed: {}", uv_strerror(rc));
Expand Down Expand Up @@ -693,6 +699,12 @@ namespace asynchost

void on_connect(int rc)
{
if (uv_is_closing((uv_handle_t*)&uv_handle) != 0)
{
LOG_DEBUG_FMT("on_connect: closing");
return;
}

if (rc < 0)
{
// Try again on the next address.
Expand Down
Loading