Skip to content
This repository was archived by the owner on Jul 21, 2025. It is now read-only.

Conversation

@akshay-online
Copy link
Collaborator

This pull request includes changes to the ADOGenerator project, focusing on improving error handling, validating file content, and updating repository configurations for multiple templates. The most important changes include catching general exceptions, validating extension file content, and updating repository URLs and service endpoints.

Error Handling Improvements:

  • Modified catch block to catch general exceptions and log error messages in src/ADOGenerator/Program.cs.

Validation Enhancements:

  • Added validation to check if the extensions file is empty before parsing in bool ValidateExtensions method in src/ADOGenerator/Program.cs.

Repository and Service Endpoint Updates:

  • Updated repository URL and service endpoint configurations in multiple JSON files to reflect new GitHub URLs and service endpoint names:
    • src/ADOGenerator/Templates/MSL-Create-Build-Pipeline/ImportSourceCode/mslearn-tailspin-spacegame-web.json
    • src/ADOGenerator/Templates/MSL-Deploy-Docker-Template/BuildDefinitions/mslearn-tailspin-spacegame-web-deploy.json
    • src/ADOGenerator/Templates/MSL-Deploy-Kubernetes-Template/BuildDefinitions/mslearn-tailspin-spacegame-web-deploy.json

Codebase Simplification:

  • Removed outdated repository and service endpoint JSON files to clean up the project:
    • src/ADOGenerator/Templates/MSL-Create-Build-Pipeline/ImportSourceCode/GitRepository.json
    • src/ADOGenerator/Templates/MSL-Deploy-Docker-Template/ImportSourceCode/GitRepository.json
    • src/ADOGenerator/Templates/MSL-Deploy-Kubernetes-Template/ImportSourceCode/GitRepository.json

Directory Management:

  • Added logic to create an Errors Log Directory if it does not exist in public static void AddMessage method in src/ADOGenerator/ServiceExtensions.cs.

Broaden exception handling in Program.cs to catch general exceptions and log error messages. Add a validation check in ValidateExtensions method to return false if extensionsFile is null or empty.
Updated repository URLs to point to the new GitHub account (`jamcneil`) for `mslearn-tailspin-spacegame-web` and related projects. Modified JSON files to include new properties for continuous integration and standardized project names. Removed references to old MicrosoftDocs repositories and retained authorization details for the new URLs. This reflects a complete migration of the project repositories.
@akshay-online akshay-online requested a review from Copilot April 4, 2025 05:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@akshay-online akshay-online requested a review from Copilot April 4, 2025 05:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@akshay-online akshay-online requested a review from Copilot April 4, 2025 05:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@akshay-online akshay-online requested a review from Copilot April 4, 2025 13:19

This comment was marked as off-topic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants