This repository was archived by the owner on Jul 21, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broaden exception handling in Program.cs to catch general exceptions and log error messages. Add a validation check in ValidateExtensions method to return false if extensionsFile is null or empty.
…ew configurations for GitHub sources 🌐
Updated repository URLs to point to the new GitHub account (`jamcneil`) for `mslearn-tailspin-spacegame-web` and related projects. Modified JSON files to include new properties for continuous integration and standardized project names. Removed references to old MicrosoftDocs repositories and retained authorization details for the new URLs. This reflects a complete migration of the project repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
gloridelmorales
approved these changes
Apr 7, 2025
This was referenced Apr 9, 2025
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
ADOGeneratorproject, focusing on improving error handling, validating file content, and updating repository configurations for multiple templates. The most important changes include catching general exceptions, validating extension file content, and updating repository URLs and service endpoints.Error Handling Improvements:
catchblock to catch general exceptions and log error messages insrc/ADOGenerator/Program.cs.Validation Enhancements:
bool ValidateExtensionsmethod insrc/ADOGenerator/Program.cs.Repository and Service Endpoint Updates:
src/ADOGenerator/Templates/MSL-Create-Build-Pipeline/ImportSourceCode/mslearn-tailspin-spacegame-web.jsonsrc/ADOGenerator/Templates/MSL-Deploy-Docker-Template/BuildDefinitions/mslearn-tailspin-spacegame-web-deploy.jsonsrc/ADOGenerator/Templates/MSL-Deploy-Kubernetes-Template/BuildDefinitions/mslearn-tailspin-spacegame-web-deploy.jsonCodebase Simplification:
src/ADOGenerator/Templates/MSL-Create-Build-Pipeline/ImportSourceCode/GitRepository.jsonsrc/ADOGenerator/Templates/MSL-Deploy-Docker-Template/ImportSourceCode/GitRepository.jsonsrc/ADOGenerator/Templates/MSL-Deploy-Kubernetes-Template/ImportSourceCode/GitRepository.jsonDirectory Management:
public static void AddMessagemethod insrc/ADOGenerator/ServiceExtensions.cs.