feat : Adding support for YAML serialization/deserialization#1283
feat : Adding support for YAML serialization/deserialization#1283ZARAYACH wants to merge 18 commits into
Conversation
… bugs and problems
3d50f94 to
9f93813
Compare
e55ecd4 to
9dfb800
Compare
| implementation(mn.micronaut.context) | ||
| implementation(mn.micronaut.core) | ||
| implementation(projects.micronautSerdeApi) | ||
| implementation(mn.snakeyaml) |
There was a problem hiding this comment.
I thought there was a lower level dependency we could depend on here?
There was a problem hiding this comment.
If you meant low level one is snakeyaml engine. No we can't depend on snake-yaml engine, Bacause The Core BOM currently exposes only org.yaml:snakeyaml.
and if you want to introduce org.snakeyaml:snakeyaml-engine in the Bom or libs-version.toml we only need to replace org.yaml.snakeyaml.* APIs with org.snakeyaml.engine.v2.* imports with small changes.
-I've test it locally no break changes on the pr.
There was a problem hiding this comment.
@graemerocher also the jackson-databind itself rely on the snakeyaml-engine as dependency as well.
which is technically the same low level classes(Emitter, Event, Node ...) I used in encoder and decoder.
There was a problem hiding this comment.
the point is to depend only on org.snakeyaml:snakeyaml-engine not on the entirety of snakeyaml
9dfb800 to
d0047f5
Compare
d01da7a to
3ffc7d1
Compare
3ffc7d1 to
c1e4e45
Compare
ed5846c to
e462e24
Compare
|
This current implementation now lacking these configuration as the upstream jackson-dataformat-yaml does :
these limitation is because micronaut-serialization not supporting @JsonIdentityInfo & @JsonIdentityReference. imo Native type IDs would need a separate cross-module feature. these are the jackson tests for the desired behavior : Tests. |
This pr aims to add support for YAML serialization/deserialization