Add reproducer for Optional getter with String property to serde-jackson-tck#1237
Draft
graemerocher with Copilot wants to merge 4 commits into
Draft
Add reproducer for Optional getter with String property to serde-jackson-tck#1237graemerocher with Copilot wants to merge 4 commits into
graemerocher with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: graemerocher <66626+graemerocher@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add reproducer for DemoSerdeTest in serde-jackson-tck
Add reproducer for Optional getter with String property to serde-jackson-tck
Jan 16, 2026
graemerocher
requested changes
Jan 16, 2026
|
|
||
| import io.micronaut.serde.jackson.OptionalGetterSpec | ||
|
|
||
| class DatabindOptionalGetterSpec extends OptionalGetterSpec { |
Contributor
There was a problem hiding this comment.
also add the equivalent test to test-suite-tck-serde
Contributor
Author
There was a problem hiding this comment.
Added equivalent test in commit 55a2062. The test is marked with @Ignore as it fails in pure Serde (demonstrating the issue), while passing in Jackson Databind.
Co-authored-by: graemerocher <66626+graemerocher@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds a TCK test case for serialization/deserialization of a class where the getter returns
Optional<String>but the field and setter use plainString.Changes
serde-jackson-tck/src/main/java/io/micronaut/serde/jackson/optionalwrap/MyThing.java- Test class demonstrating the patternserde-jackson-tck/src/main/groovy/io/micronaut/serde/jackson/OptionalGetterSpec.groovy- Abstract spec with round-trip and deserialization teststest-suite-tck-jackson-databind/.../DatabindOptionalGetterSpec.groovy- Concrete implementation for Jackson Databind (passes)test-suite-tck-serde/.../SerdeOptionalGetterSpec.groovy- Concrete implementation for pure Serde (marked@Ignoreas reproducer - demonstrates the issue)Test case
Test behavior
@Ignore) - demonstrates the issue that needs fixingOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.