-
Notifications
You must be signed in to change notification settings - Fork 26
Record deserialization fails when there are custom constructors #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
radovanradic
wants to merge
4
commits into
2.15.x
Choose a base branch
from
record-multiconstructor-deser
base: 2.15.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5624c73
Record deserialization fails when there are custom constructors
radovanradic 6ffd921
Remove global property for test
radovanradic 8d99d8e
Merge remote-tracking branch 'origin/2.15.x' into record-multiconstru…
radovanradic f6529ea
Note about @JsonCreator
radovanradic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
serde-jackson/src/test/groovy/io/micronaut/serde/jackson/MyRecord.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package io.micronaut.serde.jackson; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import io.micronaut.core.annotation.Nullable; | ||
| import io.micronaut.serde.annotation.Serdeable; | ||
|
|
||
| import java.time.Instant; | ||
| import java.util.Date; | ||
|
|
||
| @Serdeable | ||
| record MyRecord(String fooBar, int abcXyz, @Nullable Date theDate, @Nullable String otherStr) { | ||
|
|
||
| // TODO: Adding this annotation fixes issue | ||
| // @JsonCreator | ||
| MyRecord { | ||
| if (theDate == null) { | ||
| theDate = Date.from(Instant.now()); | ||
| } | ||
| } | ||
|
|
||
| public MyRecord(String fooBar, int abcXyz, Date theDate) { | ||
| this(fooBar, abcXyz, theDate, "random"); | ||
| } | ||
|
|
||
| public MyRecord(String fooBar, int abcXyz) { | ||
| this(fooBar, abcXyz, Date.from(Instant.now()), "random"); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
@JsonCreatorhere resolves the issue btw.