Add Kotlin tagsOf for pairs - #7806
Open
Develop-KIM wants to merge 1 commit into
Open
Conversation
Signed-off-by: Develop-KIM <kimdonghwan913@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #7730, which I closed by mistake — I was clearing out my open PRs across repos and this one got caught in the sweep. I deleted the fork at the same time, so GitHub would not let me reopen it. Same commit, no changes.
Fixes gh-4960
This adds a Kotlin
tagsOfutility for creatingTagsfromPair<String, String>values:This keeps the convenience API in Kotlin source so Java users do not see a Kotlin-specific
PairAPI onTags.Verification:
./gradlew :micrometer-core:spotlessKotlinCheck :micrometer-core:compileKotlin :micrometer-core:compileTestKotlinNote:
./gradlew :micrometer-core:test --tests io.micrometer.core.instrument.kotlin.TagsKtTestscurrently fails before running the test due to existing NullAway errors in unrelated Java tests (StepMeterRegistryTestandMeterTest).