Add ESP32 Ethernet transport #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pablogs9 can you please review this PR? |
pablogs9
reviewed
Feb 20, 2025
Member
pablogs9
left a comment
pablogs9
left a comment
There was a problem hiding this comment.
As a general comment, why is this already available ethernet transport not compatible?
Contributor
Author
ESP32 does not have native ethernet, but widely uses the LAN8710 chip to add it. This is what this PR enables. |
pablogs9
approved these changes
Feb 21, 2025
Member
|
Hey, @patrickwasp the CI has failed due to a small issue with another package, I have solved it here: #171. Could you address my single comment and rebase your PR on top of the latest commit of Thanks a lot for the contribution! |
Co-authored-by: Pablo Garrido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for ESP32 ETH.h ethernet.