Draft
Conversation
Member
|
Hi @chelloiaco Thanks for the PR. I will check it ASAP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
I noticed that the reason why the actions were failing was due to the fact that flask8 was looking for a folder
python, which perhaps existed at some point but does not anymore. Same with Radon.In the effort to have the actions be useful again, I added some functionality to the test to run only on Python files that have been changed (Added, Copied, Modified, Renamed). Additionally, I removed the
--exit-zeroargument from flask8 so we actually get a fail if the code does not meet the standards.Let me know what you think.
Testing Done
I have tested this by temporarily adding the branch name into the branches candidates on the
code_quality.ymlfile as seen on the commits history for this PR.