fix: empty token overrides provider default + hardcoded error message#20
Merged
Conversation
- setup.ts: don't save token when empty so provider default kicks in - cli.ts: treat empty-string config values as undefined in ?? chain - cli.ts: error messages show actual provider name + suggest setup - setup.ts: show provider defaults in prompts when saved value differs
mforce
force-pushed
the
fix/empty-token-config
branch
from
0792403 to
a692ca7
Compare
added 2 commits
May 3, 2026 20:40
…token When a saved config exists with a value differing from the provider default, the wizard now shows a select menu with three options: - Current saved value - Provider default - Custom (opens text input) On first run (no saved config), shows a simple text input with the provider default pre-filled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bugs found during smoke testing of
claudely setup:Empty token saved as
""—??treats empty string as defined, blocking fallthrough to provider default (e.g."lmstudio"). Now: empty token omitted from saved config, and cli.ts treats empty config strings as undefined.Error message hardcodes
'custom'—"provider 'custom' requires --token"fired for ALL providers. Now shows actual provider name and suggestsclaudely setup.Setup wizard doesn't show provider defaults — prompts now show
(provider default: lmstudio)when the saved value differs from the default.Test plan
npm test— 88 passclaudely setup→ select lmstudio → clear token → saves without token fieldclaudely --newafter empty token → uses provider default, no errorclaudely setup→ prompts show provider defaults