feat: support pkg-config across all platforms#157
Open
JyJyJcr wants to merge 1 commit intometno:mainfrom
Open
Conversation
Collaborator
|
We will have to update all dependents of hdf5-sys to not use standard features and put pkg-config at toplevel hdf5. Unless your usecase is only using the hdf5-sys directly |
Collaborator
|
Or we can always use pkg-config and fall back to other methods if pkg-config is failing. I am unfamiliar with pkg-config outside of linux, is it widely adopted? |
Author
|
At least on macOS, pkg-config is commonly used in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some macOS users (e.g., those using nix-darwin) rely on pkg-config to locate HDF5, but the current build script only checks Homebrew. Additionally, on Windows, if both a registry-detected version and a pkg-config version are available, the script does not allow selecting the pkg-config version.
This PR introduces a new
pkg-configfeature flag to explicitly enable HDF5 detection via pkg-config. The library search logic is updated to try pkg-config first on all operating systems when this feature is enabled.For backward compatibility, this feature is enabled by default.