sonic-exporter to gnmic migration - #670
Conversation
e4214c2 to
fd727dd
Compare
simcod
left a comment
simcod
left a comment
There was a problem hiding this comment.
Great, thank you for this valuable contribution!
It would be great, to add a migration guide as we have in place for alloy/promtail. How about providing an option to remove the sonic-exporter?
Depending on the migration, we should also add an Action Required or Noteworthy section in the pull request description.
ma-hartma
added
the
requires docs update
|
Please also update https://metal-stack.io/docs/next/monitoring, it mentions sonic-exporter multiple times. |
|
|
||
| - name: Set port list | ||
| ansible.builtin.set_fact: | ||
| monitoring_gnmic_ports: "{{ (monitoring_gnmic_port_json.stdout | from_json).keys() | select('match', '^Ethernet[0-9]+$') | list }}" |
There was a problem hiding this comment.
maybe adjust this select to match all ports starting with Eth so different naming schemes are supported as well.
ma-hartma
left a comment
ma-hartma
left a comment
There was a problem hiding this comment.
Thanks for implementing all the changes. This looks really good now.
I only see this comment left, but I think it is optional and up to you @Sven-Ric #670 (comment).
As we will deprecate the sonic-exporter in future, we could even say it is an "Action Required" instead of a "Noteworthy".
One final request: Please update the website monitoring section as soon as possible.
ma-hartma
left a comment
ma-hartma
left a comment
There was a problem hiding this comment.
Sorry, found one last thing.
| @@ -0,0 +1,36 @@ | |||
| --- | |||
| monitoring_gnmic_image_name: "ghcr.io/openconfig/gnmic" | |||
There was a problem hiding this comment.
Please move the image tag and name to the release vector. Open an own PR in metal-stack/releases and reference the values.
5 participants
Description
The stordis monsoon sonic-exporter has been deprecated (https://github.com/STORDIS/monsoon) This role deploys gnmic to collect the same metrics and export them under the same names as the sonic-exporter.
Used AI-Tools ✨
Fable 5 was used to explore multiple to find commonalities and differences between gnmi implementations in community and enterprise SONiC. Confirmed by Hand.
Release Notes
Required Actions