Improve metacall-sys crate
#600
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solve conflicts by removing build.rs and making metacall-sys crate regular dependency
fahdfady
changed the title
metacall-sys crate
Member
|
@fahdfady I have done some changes, it may generate breaking changes. Now rust port works on windows. If you can solve the issue we should port it to the new changes I have done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to better
metacall-sysdev experience. Users should not make a build script and runmetacall-sys::buildby themselves. Like other -sys crates,metacall-sysshould link for all crates that want to link to MetaCall.