Fix generate version code to generate _version.py instead of version.py#1187
Open
AbishekS wants to merge 1 commit intometa-pytorch:mainfrom
Open
Fix generate version code to generate _version.py instead of version.py#1187AbishekS wants to merge 1 commit intometa-pytorch:mainfrom
AbishekS wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Summary: Internal **Problem:** Issue workplace post https://fb.workplace.com/groups/140700188041197/posts/1120600273384512/?comment_id=1120754030035803&reply_comment_id=1120825080028698 torchx image internally is looking for `ghcr.io/pytorch/torchx:0.8.0dev0+fb.dcb00c35540d` **Fix:** - Instead of generating the version.py we will generate the _version.py. This file will hold the VERSION used by OSS. And the generated one will hold the VERSION used by meta. - The original BASE_VERSION is moved to _base_version.py which is shared by OSS in _version.py and by fb in version_gen.py. - So this means the version.py will go back to being shared by OSS and fb as well as generating this is a very bad way to do this. Differential Revision: D91055760
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.