Enable online writing to WandB in MAST jobs #628
+45
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
JenniferWang
reviewed
Dec 8, 2025
src/forge/controller/launcher.py
Outdated
| "VLLM_USE_TRITON_FLASH_ATTN": "0", | ||
| "WANDB_MODE": "offline", | ||
| "WANDB_MODE": "online", | ||
| "WANDB_BASE_URL": "https://meta.wandb.io", |
Contributor
There was a problem hiding this comment.
i wonder if you think moving these MAST controller stuff to a separate src/forge/controller/fb/ make sense.
Contributor
Author
There was a problem hiding this comment.
yeah I think we can move MastLauncher to a separate file, I can do that after this Pr
Contributor
|
What's the steps to set up the team keychain for wandb? |
JenniferWang
reviewed
Dec 8, 2025
Comment on lines
+89
to
+92
| if wandb_api_key is not None: | ||
| os.environ["WANDB_API_KEY"] = wandb_api_key | ||
| os.environ["WANDB_BASE_URL"] = WANDB_HOST | ||
|
|
Contributor
There was a problem hiding this comment.
I think we should terminate the launcher if wandb_api_key is None.
Otherwise, it just delays the crash in MAST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we use the secrets API to extract the WandB API key and add it to the environment.
Test Plan
From logs: