Change ActorStatus::Stopped to not call unhandled #1675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85596621. |
Summary: Before, calling "proc_mesh.stop()" or "actor_mesh.stop()" would generate mesh failures that could cause the `unhandled_fault_hook` to be called, even if those meshes were not used afterwards. This created a negative user experience, and wasn't making a useful error message. To fix this, distinguish between requested stops and unrequested failures. The former does not cause a client crash, and the latter does. Requested stops will still make proc meshes and actor meshes unusable (cannot spawn new actors, cannot message existing actors) and the error messages will include that the mesh was stopped. Also, on the side, include the mesh name with the mesh failure. This wasn't always included with the ActorSupervisionEvent (particularly for stopping), and it's very helpful to have when an error occurs. Differential Revision: D85596621
dulinriley
force-pushed
the
export-D85596621
branch
from
34ac614 to
c0bb1ee
Compare
|
This pull request has been merged in 6854a90. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Before, calling "proc_mesh.stop()" or "actor_mesh.stop()" would generate mesh
failures that could cause the
unhandled_fault_hookto be called, even if those mesheswere not used afterwards.
This created a negative user experience, and wasn't making a useful error message. To fix
this, distinguish between requested stops and unrequested failures. The former does not
cause a client crash, and the latter does.
Requested stops will still make proc meshes and actor meshes unusable (cannot spawn new
actors, cannot message existing actors) and the error messages will include that the mesh was
stopped.
Also, on the side, include the mesh name with the mesh failure. This wasn't always included
with the ActorSupervisionEvent (particularly for stopping), and it's very helpful to have when an error occurs.
Differential Revision: D85596621