[monarch] don't abort in-progress proc state checks #1670
Closed
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not currently cancellation safe because dropping the rx will cause messages to be undelivered, supervision to kick in, and the job to fail. Instead, we thread through a cancellation token so that we can safely cancel these tasks, resolving the race. Differential Revision: [D85577198](https://our.internmc.facebook.com/intern/diff/D85577198/) [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Oct 27, 2025
These are not currently cancellation safe because dropping the rx will cause messages to be undelivered, supervision to kick in, and the job to fail. Instead, we thread through a cancellation token so that we can safely cancel these tasks, resolving the race. Differential Revision: [D85577198](https://our.internmc.facebook.com/intern/diff/D85577198/) ghstack-source-id: 318934604 Pull Request resolved: #1670
meta-cla
bot
added
the
CLA Signed
These are not currently cancellation safe because dropping the rx will cause messages to be undelivered, supervision to kick in, and the job to fail. Instead, we thread through a cancellation token so that we can safely cancel these tasks, resolving the race. Differential Revision: [D85577198](https://our.internmc.facebook.com/intern/diff/D85577198/) [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Oct 27, 2025
Pull Request resolved: #1670 These are not currently cancellation safe because dropping the rx will cause messages to be undelivered, supervision to kick in, and the job to fail. Instead, we thread through a cancellation token so that we can safely cancel these tasks, resolving the race. Differential Revision: [D85577198](https://our.internmc.facebook.com/intern/diff/D85577198/) ghstack-source-id: 318976646
These are not currently cancellation safe because dropping the rx will cause messages to be undelivered, supervision to kick in, and the job to fail. Instead, we thread through a cancellation token so that we can safely cancel these tasks, resolving the race. Differential Revision: [D85577198](https://our.internmc.facebook.com/intern/diff/D85577198/) [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Oct 27, 2025
Pull Request resolved: #1670 These are not currently cancellation safe because dropping the rx will cause messages to be undelivered, supervision to kick in, and the job to fail. Instead, we thread through a cancellation token so that we can safely cancel these tasks, resolving the race. ghstack-source-id: 318994668 Differential Revision: [D85577198](https://our.internmc.facebook.com/intern/diff/D85577198/)
|
This pull request has been merged in 9b48962. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: meta-pytorch#1670 These are not currently cancellation safe because dropping the rx will cause messages to be undelivered, supervision to kick in, and the job to fail. Instead, we thread through a cancellation token so that we can safely cancel these tasks, resolving the race. ghstack-source-id: 318994668 Reviewed By: dulinriley Differential Revision: D85577198 fbshipit-source-id: dcf3d5f91cd95c5f783131ed9511eda1db045efc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These are not currently cancellation safe because dropping the rx will cause messages to be undelivered, supervision to kick in, and the job to fail.
Instead, we thread through a cancellation token so that we can safely cancel these tasks, resolving the race.
Differential Revision: D85577198