Cache rdma availability result. And add a check for mlx5dv extension availability. #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
casteryh
force-pushed
the
export-D85504060
branch
from
77f7ccd to
78aec89
Compare
casteryh
added a commit
to casteryh/monarch
that referenced
this pull request
Oct 27, 2025
…availability. (meta-pytorch#1664) Summary: Add a check for mlx5dv extension availability. Turns out these calls are quite expensive, so we also cache the result. This saves 0.2ms for buffer creation on average. Differential Revision: D85504060
casteryh
force-pushed
the
export-D85504060
branch
from
78aec89 to
b381685
Compare
casteryh
added a commit
to casteryh/monarch
that referenced
this pull request
Oct 27, 2025
…availability. (meta-pytorch#1664) Summary: Add a check for mlx5dv extension availability. Turns out these calls are quite expensive, so we also cache the result. This saves 0.2ms for buffer creation on average. Differential Revision: D85504060
casteryh
added a commit
to casteryh/monarch
that referenced
this pull request
Oct 28, 2025
…availability. (meta-pytorch#1664) Summary: Add a check for mlx5dv extension availability. Turns out these calls are quite expensive, so we also cache the result. This saves 0.2ms for buffer creation on average. Reviewed By: dstaay-fb Differential Revision: D85504060
…availability. (meta-pytorch#1664) Summary: Add a check for mlx5dv extension availability. Turns out these calls are quite expensive, so we also cache the result. This saves 0.2ms for buffer creation on average. Reviewed By: dstaay-fb Differential Revision: D85504060
casteryh
force-pushed
the
export-D85504060
branch
from
b381685 to
01a1431
Compare
|
This pull request has been merged in d9b1030. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add a check for mlx5dv extension availability. Turns out these calls are quite expensive, so we also cache the result. This saves 0.2ms for buffer creation on average.
Differential Revision: D85504060