[hyperactor] implement a grace period for stalled client loops #1634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements a grace period whenever the client loop stalls. Specifically, we reset the ack timeout when such stalls occur, giving the channel time to recover from underlying issues. Differential Revision: [D85187188](https://our.internmc.facebook.com/intern/diff/D85187188/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85187188/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Oct 21, 2025
This change implements a grace period whenever the client loop stalls. Specifically, we reset the ack timeout when such stalls occur, giving the channel time to recover from underlying issues. Differential Revision: [D85187188](https://our.internmc.facebook.com/intern/diff/D85187188/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85187188/)! ghstack-source-id: 317768313 Pull Request resolved: #1634
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This change implements a grace period whenever the client loop stalls. Specifically, we reset the ack timeout when such stalls occur, giving the channel time to recover from underlying issues.
Differential Revision: D85187188
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!