Skip to content

Enable two tests in OSS again #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable two tests in OSS again #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions hyperactor_mesh/src/alloc/remoteprocess.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,8 +779,7 @@ impl RemoteProcessAlloc {
}
ChannelTransport::Tcp(TcpMode::Localhost) => {
// TODO: @rusch see about moving over to config for this
let ip = IpAddr::V6(Ipv6Addr::LOCALHOST);
format!("tcp!{}:{}", ip, self.remote_allocator_port)
format!("tcp![::1]:{}", self.remote_allocator_port)
}
ChannelTransport::Tcp(TcpMode::Hostname) => {
format!("tcp!{}:{}", host.hostname, self.remote_allocator_port)
Expand Down
8 changes: 4 additions & 4 deletions python/tests/test_allocator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,8 +606,6 @@ async def test_torchx_remote_alloc_initializer_no_match_label_gt_1_meshes(
AllocSpec(AllocConstraints(), host=1, gpu=1)
).initialized

# Skipping test temporarily due to blocking OSS CI TODO: @rusch T232884876
@pytest.mark.oss_skip # pyre-ignore[56]: Pyre cannot infer the type of this pytest marker
async def test_torchx_remote_alloc_initializer_no_match_label_1_mesh(self) -> None:
server = ServerSpec(
name=UNUSED,
Expand All @@ -623,9 +621,11 @@ async def test_torchx_remote_alloc_initializer_no_match_label_1_mesh(self) -> No
],
)
port = get_free_port()
os.environ["HYPERACTOR_REMOTE_ALLOC_BIND_TO_INADDR_ANY"] = "true"

with remote_process_allocator(
addr=f"tcp!{get_sockaddr('localhost', port)}",
envs={"HYPERACTOR_REMOTE_ALLOC_BIND_TO_INADDR_ANY": "true"},
):
with mock.patch(SERVER_READY, return_value=server):
initializer = TorchXRemoteAllocInitializer("local:///test", port=port)
Expand All @@ -641,8 +641,6 @@ async def test_torchx_remote_alloc_initializer_no_match_label_1_mesh(self) -> No
)
self.assert_computed_world_size(results, 4) # 1x4 mesh

# Skipping test temporarily due to blocking OSS CI TODO: @rusch T232884876
@pytest.mark.oss_skip # pyre-ignore[56]: Pyre cannot infer the type of this pytest marker
async def test_torchx_remote_alloc_initializer_with_match_label(self) -> None:
server = ServerSpec(
name=UNUSED,
Expand All @@ -658,9 +656,11 @@ async def test_torchx_remote_alloc_initializer_with_match_label(self) -> None:
],
)
port = get_free_port()
os.environ["HYPERACTOR_REMOTE_ALLOC_BIND_TO_INADDR_ANY"] = "true"

with remote_process_allocator(
addr=f"tcp!{get_sockaddr('localhost', port)}",
envs={"HYPERACTOR_REMOTE_ALLOC_BIND_TO_INADDR_ANY": "true"},
):
with mock.patch(SERVER_READY, return_value=server):
initializer = TorchXRemoteAllocInitializer("local:///test", port=port)
Expand Down
Loading