TST: use the recommended subprocess API

Author: dnicolodi

tests/conftest.py

@@ -48,11 +48,11 @@ def in_git_repo_context(path=os.path.curdir):
     path = os.path.abspath(path)
     shutil.rmtree(os.path.join(path, '.git'), ignore_errors=True)
     try:
-        subprocess.check_call(['git', 'init', '-b', 'main', path])
-        subprocess.check_call(['git', 'config', 'user.email', '[email protected]'], cwd=path)
-        subprocess.check_call(['git', 'config', 'user.name', 'A U Thor'], cwd=path)
-        subprocess.check_call(['git', 'add', '*'], cwd=path)
-        subprocess.check_call(['git', 'commit', '-q', '-m', 'Test'], cwd=path)
+        subprocess.run(['git', 'init', '-b', 'main', path], check=True)
+        subprocess.run(['git', 'config', 'user.email', '[email protected]'], cwd=path, check=True)
+        subprocess.run(['git', 'config', 'user.name', 'A U Thor'], cwd=path, check=True)
+        subprocess.run(['git', 'add', '*'], cwd=path, check=True)
+        subprocess.run(['git', 'commit', '-q', '-m', 'Test'], cwd=path, check=True)
         yield
     finally:
         # PermissionError raised on Windows.

tests/docs/examples/test_spam.py

@@ -19,11 +19,11 @@ def test_build_and_import(venv, tmp_dir_session):
     else:
         wheel = build_project_wheel(package=examples_dir / 'spam', outdir=tmp_dir_session)
 
-        subprocess.check_call([
-            venv.executable, '-m', 'pip', 'install', wheel
-        ])
-        output = subprocess.check_output([
-            venv.executable, '-c', 'import spam; print(spam.add(1, 2))'
-        ])
+        subprocess.run(
+            [venv.executable, '-m', 'pip', 'install', wheel],
+            check=True)
+        output = subprocess.run(
+            [venv.executable, '-c', 'import spam; print(spam.add(1, 2))'],
+            check=True, stdout=subprocess.PIPE).stdout
 
         assert int(output) == 3

tests/test_project.py

@@ -65,7 +65,7 @@ def last_two_meson_args():
 
     # create the build directory ourselves because Project._meson is mocked
     builddir = str(tmp_dir_session / 'build')
-    subprocess.check_call(['meson', 'setup', '.', builddir])
+    subprocess.run(['meson', 'setup', '.', builddir], check=True)
 
     config_settings = {
         'builddir': builddir,  # use the build directory we created

tests/test_wheel.py

@@ -141,12 +141,14 @@ def test_configure_data(wheel_configure_data):
 
 @pytest.mark.skipif(platform.system() != 'Linux', reason='Unsupported on this platform for now')
 def test_local_lib(venv, wheel_link_against_local_lib):
-    subprocess.check_call([
-        venv.executable, '-m', 'pip', 'install', wheel_link_against_local_lib
-    ])
-    assert subprocess.check_output([
-        venv.executable, '-c', 'import example; print(example.example_sum(1, 2))'
-    ]).decode().strip() == '3'
+    subprocess.run(
+        [venv.executable, '-m', 'pip', 'install', wheel_link_against_local_lib],
+        check=True)
+    output = subprocess.run(
+        [venv.executable, '-c', 'import example; print(example.example_sum(1, 2))'],
+        stdout=subprocess.PIPE,
+        check=True).stdout
+    assert int(output) == 3
 
 
 def test_contents_license_file(wheel_license_file):