TST: disable pip version check for all tests

Author: dnicolodi

tests/conftest.py

@@ -123,6 +123,14 @@ def fixture(tmp_dir_session):
     globals()[f'wheel_{normalized}'] = generate_wheel_fixture(package)
 
 
+@pytest.fixture(autouse=True, scope='session')
+def disable_pip_version_check():
+    # Cannot use the 'monkeypatch' fixture because of scope mismatch.
+    mpatch = pytest.MonkeyPatch()
+    yield mpatch.setenv('PIP_DISABLE_PIP_VERSION_CHECK', '1')
+    mpatch.undo()
+
+
 @pytest.fixture(scope='session')
 def pep518_wheelhouse(tmpdir_factory):
     wheelhouse = tmpdir_factory.mktemp('wheelhouse')

tests/docs/examples/test_spam.py

@@ -20,7 +20,7 @@ def test_build_and_import(venv, tmp_dir_session):
         wheel = build_project_wheel(package=examples_dir / 'spam', outdir=tmp_dir_session)
 
         subprocess.check_call([
-            venv.executable, '-m', 'pip', '--disable-pip-version-check', 'install', wheel
+            venv.executable, '-m', 'pip', 'install', wheel
         ])
         output = subprocess.check_output([
             venv.executable, '-c', 'import spam; print(spam.add(1, 2))'

tests/test_wheel.py

@@ -142,7 +142,7 @@ def test_configure_data(wheel_configure_data):
 @pytest.mark.skipif(platform.system() != 'Linux', reason='Unsupported on this platform for now')
 def test_local_lib(venv, wheel_link_against_local_lib):
     subprocess.check_call([
-        venv.executable, '-m', 'pip', '--disable-pip-version-check', 'install', wheel_link_against_local_lib
+        venv.executable, '-m', 'pip', 'install', wheel_link_against_local_lib
     ])
     assert subprocess.check_output([
         venv.executable, '-c', 'import example; print(example.example_sum(1, 2))'