Skip to content

add preamble_length to settings list - #1021

Open
dinets wants to merge 1 commit into
meshtastic:masterfrom
dinets:my_preamble2
Open

add preamble_length to settings list#1021
dinets wants to merge 1 commit into
meshtastic:masterfrom
dinets:my_preamble2

Conversation

@dinets

@dinets dinets commented Jul 26, 2026

Copy link
Copy Markdown

Adding preamble_length in Lora config list, to get ability change this parameter.

For what?

To controlling external Power Amplifier, specially for old half_duplex PA with RF relays
96d31e8a-8b38-4b5d-98a6-96665dc08aa7
15e82cfd-92b0-4773-80f3-1a5e70676ba1

Summary by CodeRabbit

  • New Features
    • Added a configurable LoRa preamble length setting.
    • Included documentation for the new configuration option.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ff2a4897-241e-4dad-b617-030b21a74191

📥 Commits

Reviewing files that changed from the base of the PR and between bfd718f and ea35c96.

📒 Files selected for processing (1)
  • meshtastic/config.proto

📝 Walkthrough

Walkthrough

LoRaConfig gains a documented uint32 preamble_length field with protobuf field number 108, following serial_hal_only.

Changes

LoRa configuration

Layer / File(s) Summary
Add LoRa preamble length field
meshtastic/config.proto
Adds the documented preamble_length field to LoRaConfig with field number 108.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: thebentern, jp-bennett

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: adding preamble_length to the LoRa settings list.
Description check ✅ Passed The description states the change and use case, but it omits the template's issue link and checklist sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants