Skip to content

build: drop newlib crt0 and let Reset_Handler call main - #73

Merged
jamesarich merged 1 commit into
build/ltofrom
build/no-crt0
Oct 24, 2026
Merged

jamesarich merged 1 commit into
build/ltofrom
build/no-crt0

Conversation

@jamesarich

Copy link
Copy Markdown
Collaborator

Checklist

  • PR title specifically describes the change
  • tools/build_all.py (or CI's board matrix) passes

Description of Change

Another 368 B. main never returns, so newlib's startup and exit machinery is dead weight; Reset_Handler copies .data, clears exactly .bss (not .noinit) and calls main.

Tested on the same four boards as LTO, merged with the rest of 2.6: boots, self-update, UF2 install, INFO_UF2.TXT and BLE OTA all fine. __libc_fini_array stays linked through atexit; it never runs.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 91763c44-8fd0-4c2f-9bbc-14a725c22414

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamesarich
jamesarich merged commit e1731c5 into build/lto Oct 24, 2026
23 checks passed
@jamesarich
jamesarich deleted the build/no-crt0 branch October 24, 2026 11:58
@jamesarich

Copy link
Copy Markdown
Collaborator Author

Folded into #72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant