Repository navigation
fix: redact debug logs, retry a stalled setup, correct two sensor classes - #257
Merged
Merged
Conversation
…sses Logged protobufs now leave out the fields the schema marks sensitive and admin payloads, since users attach startup debug logs to bug reports. A radio that stops answering mid-setup now retries like a failed connect, instead of failing until a manual reload. Wind direction is a wind_direction angle, not a wind speed, and the host user string has no numeric state class.
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three findings from the pre-0.7.0 review:
aiomeshtastic.redact.without_secrets, which drops every field the schema tagssensitiveand admin payloads.ConfigEntryNotReady, so HA retries, as it already does for a failed connect.windDirectionwas a wind speed sensor with a degree unit; it is nowwind_directionwithmeasurement_angle. The hostuserStringsensor no longer claims a numeric state class.Test plan
test_log_redaction.py, a mid-setup retry test and a wind direction test, each failing against main. ruff, mypy and pytest pass locally on Python 3.14.Checklist